MozillaZine

Silvermel and Charamel - Themes for Firefox and Thunderbird

Announce and Discuss the Latest Theme and Extension Releases.
onemen

User avatar
 
Posts: 1130
Joined: October 15th, 2004, 7:48 am

Post Posted February 9th, 2011, 12:53 pm

Hello ShareBird,

I'm working on Tabmix for version 4 and i have a question ..

in chrome.manifest i need to attach style for Mac only
which OS TARGET i need to add Darwin , OS2 ?

Thank you for advance :)

ShareBird

User avatar
 
Posts: 2740
Joined: December 8th, 2004, 7:09 am
Location: Berlin | Made in Brasil

Post Posted February 9th, 2011, 1:14 pm

Hi onemen,

you have to add os=Darwin. For example:
Code: Select all
skin      os_target             silvermel   chrome/os_target/Mac/   os=Darwin


See:
https://developer.mozilla.org/en/OS_TARGET
Silvermel - A Theme for Firefox and Thunderbird
YATT - Yet Another Theme Tutorial
Don't give a man a fish. Teach him how to fish instead.

onemen

User avatar
 
Posts: 1130
Joined: October 15th, 2004, 7:48 am

Post Posted February 9th, 2011, 2:27 pm

Thank you ShareBird,

since i'm working on Extension not a theme i have something like this
Code: Select all
skin      tabmixplus   classic/1.0    chrome/skin/
style   chrome://browser/content/browser.xul   chrome://tabmixplus/skin/progress-winstripe.css           appversion>=4.0b7pre os!=Darwin
style   chrome://browser/content/browser.xul   chrome://tabmixplus/skin/progress-pinstripe.css           appversion>=4.0b7pre os=Darwin


i'm working on separating the css rules into different file by appversion and OS (OS_TARGET)
Tabmix support version 3.5.* 3.6.* and upcoming 4.0
so in the end i will have at least 9-12 files

common - for all OS.
then files for WINNT(xp, aero), Linux and Darwin.
for each OS i have different set of rules for each Firefox version

so what is the best approach for this case?

ShareBird

User avatar
 
Posts: 2740
Joined: December 8th, 2004, 7:09 am
Location: Berlin | Made in Brasil

Post Posted February 9th, 2011, 9:14 pm

Hi onemen, this is a very good question indeed. I don't know how exactly we could solve this, I guess the best approach could be to define a style overlay for each one of the several OSs using the manifest flags and use the approach I'm using for the several appversions registering a skin package to accommodate the code (something like tabmixplus_appversion, taking care to not pollute the "chrome namespace")... Please let me think a little bit more about this issue, ok?

Ahh.. A side note, I've stopped to register a skin provider for the tabmixplus package, because it's very difficult to track the modifications on Firefox, Thunderbird and TMP at the same time... So, I will probably have some problems to support TMP as I did in the past...

And now, the new versions: :-)

Silvermel:
http://www.silvermel.de/dev/xpi/silverm ... _r4392.xpi

Charamel:
http://www.silvermel.de/dev/xpi/charame ... _r4392.xpi
Silvermel - A Theme for Firefox and Thunderbird
YATT - Yet Another Theme Tutorial
Don't give a man a fish. Teach him how to fish instead.

onemen

User avatar
 
Posts: 1130
Joined: October 15th, 2004, 7:48 am

Post Posted February 10th, 2011, 12:32 pm

its look ok on Tabmix dev-build on Firefox 4.0b12pre

mightyglydd

User avatar
 
Posts: 9247
Joined: November 4th, 2006, 7:07 pm
Location: Hollywood Ca.

Post Posted February 10th, 2011, 6:58 pm

Hmm, seems to be a conflict with Status-4-Evar here on XP Pro SP3, this is what I'm seeing with it enabled......

Image

When It's disabled the address bar looks fine, this wasn't happening with the previous version.

Other than that, lookin' good !........
#KeepFightingMichael

ShareBird

User avatar
 
Posts: 2740
Joined: December 8th, 2004, 7:09 am
Location: Berlin | Made in Brasil

Post Posted February 10th, 2011, 8:49 pm

mightyglydd wrote:Hmm, seems to be a conflict with Status-4-Evar here on XP Pro SP3, this is what I'm seeing with it enabled......

Image

When It's disabled the address bar looks fine, this wasn't happening with the previous version.

Other than that, lookin' good !........


Oh... I see... This is because of
Change_Log wrote:fixed urlbar appearance - was broken after the patch for Bug 541656 - Display hyperlink URLs at bottom of window (instead of right side of location bar)

The bindings part will be removed after Bug 631812 - URLBar broken on certain themes get fixed.

Since the bug was marked today as FIXED, it will be in the tomorrow's build and I will remove the bindings. So, tomorrow new versions :-)

P.S. - I've noticed something strange in your screenshot... Are you using XP Theme Royale Noir? The new tab button should actually be white...
Silvermel - A Theme for Firefox and Thunderbird
YATT - Yet Another Theme Tutorial
Don't give a man a fish. Teach him how to fish instead.

mightyglydd

User avatar
 
Posts: 9247
Joined: November 4th, 2006, 7:07 pm
Location: Hollywood Ca.

Post Posted February 10th, 2011, 10:02 pm

ShareBird wrote: Are you using XP Theme Royale Noir? The new tab button should actually be white...


Yes I am, and didn't notice the button....for obvious reasons. :)

@The 'List All Tabs' button's the same, max/min buttons are white, X is white on red.
#KeepFightingMichael

ShareBird

User avatar
 
Posts: 2740
Joined: December 8th, 2004, 7:09 am
Location: Berlin | Made in Brasil

Post Posted February 11th, 2011, 6:49 am

Hmmmm... It should look like:
Image

Uploaded with ImageShack.us
Silvermel - A Theme for Firefox and Thunderbird
YATT - Yet Another Theme Tutorial
Don't give a man a fish. Teach him how to fish instead.

mightyglydd

User avatar
 
Posts: 9247
Joined: November 4th, 2006, 7:07 pm
Location: Hollywood Ca.

Post Posted February 11th, 2011, 10:46 am

I'll reset toolbars & controls and do an add-ons 'diagnostic', probably messed something up, I'll report back this evening...
#KeepFightingMichael

ShareBird

User avatar
 
Posts: 2740
Joined: December 8th, 2004, 7:09 am
Location: Berlin | Made in Brasil

Post Posted February 11th, 2011, 11:54 am

Thank you very much mightyglydd!

I will post new versions also today evening...
Silvermel - A Theme for Firefox and Thunderbird
YATT - Yet Another Theme Tutorial
Don't give a man a fish. Teach him how to fish instead.

ShareBird

User avatar
 
Posts: 2740
Joined: December 8th, 2004, 7:09 am
Location: Berlin | Made in Brasil

Post Posted February 11th, 2011, 4:37 pm

Silvermel - A Theme for Firefox and Thunderbird
YATT - Yet Another Theme Tutorial
Don't give a man a fish. Teach him how to fish instead.

mightyglydd

User avatar
 
Posts: 9247
Joined: November 4th, 2006, 7:07 pm
Location: Hollywood Ca.

Post Posted February 11th, 2011, 6:46 pm

OK ShareBird, disabled all add-ons reset toolbars & controls and the buttons are still dark.
When I downloaded the latest version the address bar's now like my screenshot with all add-ons (including S4E) disabled and the buttons remain dark.
Last thing I tried was temporally removing my userChrome folder/tweaks.... no change.
Sorry I don't have better news to report, maybe it's because I'm on b11, the address bar problem wasn't happening a couple of versions back.

MG. :-k
#KeepFightingMichael

ShareBird

User avatar
 
Posts: 2740
Joined: December 8th, 2004, 7:09 am
Location: Berlin | Made in Brasil

Post Posted February 11th, 2011, 6:51 pm

mightyglydd wrote:Sorry I don't have better news to report, maybe it's because I'm on b11...

OK. That's it! Sorry I thought you were on b12pre (I need to read the signatures more accurately...) I can't maintain compatibility with the betas, the Firefox code has change a lot in the meantime. But why you don't use the nightlies? IMO the nightlies are more stable as the betas :-)
Silvermel - A Theme for Firefox and Thunderbird
YATT - Yet Another Theme Tutorial
Don't give a man a fish. Teach him how to fish instead.

mightyglydd

User avatar
 
Posts: 9247
Joined: November 4th, 2006, 7:07 pm
Location: Hollywood Ca.

Post Posted February 11th, 2011, 7:55 pm

Aha, Good! I figured it was something my end.
I'll just go back and enjoy a version that I know works until FF4 goes primetime.
As for nightlies, I know my limitations with this stuff, at least if I stick with Betas, when a new one arrives I've spent enough time with the old one to recognize changes.
Rock On....MG :)
#KeepFightingMichael

Return to Extension/Theme Releases


Who is online

Users browsing this forum: No registered users and 3 guests