Firefox nightly theme changes

Discuss application theming and theme development.
Post Reply
User avatar
akayser
Posts: 299
Joined: August 25th, 2010, 12:44 am

Firefox nightly theme changes

Post by akayser »

This is the starting message for the thread that contains the firefox theme changes for the releases after 4.0.
It will track all changes in the 'nightly' channel, as it is unknown yet what changes will end up in which release.

The first couple are most styling changes:
Bug 639286 - Replace thick transparent border on tabs with proper CSS padding.
Bug 643628 - Last updated date misplaced in search results.
Bug 639896 - The window controls look reversed in full-screen mode for RTL versions of Firefox
Bug 637212 - Bookmarks toolbar has an unwanted border in maximized windows with tabs on bottom, aero glass and a lightweight theme applied.
Bug 618552 - "Undo Close Group" button does not fit for some locales
Bug 603790 - drop the drop shadow on buttons and textfields.
Bug 623199 - Add-ons manager buttons should be contextually styled.
Bug 611759 - [Pinstripe] Remove '-moz-appearance: treeheadersortarrow' from listbox.css/tree.css.
Bug 646419 - Update add-ons manager main controls for Firefox nav bar styling changes.
Bug 640490 - Adjust vertical alignment of tab labels on Windows.
Bug 465086 - When closing a tab, other tabs should not resize until cursor leaves tab toolbar.
Bug 634065 - Implement design for identity block and persistent indicators

(edit: buglinks fixed, my apologies!)
Last edited by akayser on April 22nd, 2011, 2:31 am, edited 1 time in total.
Creator of the LittleFox, LittleBird, MicroFox, MicroBird, Nautipolis, Walnut, Walnut2, Bricks and Metal themes for Firefox and Thunderbird.
Visit https://addons.mozilla.org/en-US/firefox/addon/123/developers. Mozilla contributor since October 1999 (Mozilla M10).
User avatar
patrickjdempsey
Posts: 23686
Joined: October 23rd, 2008, 11:43 am
Location: Asheville NC
Contact:

Re: Firefox nightly theme changes

Post by patrickjdempsey »

All of your links go to the same bug.
Tip of the day: If it has "toolbar" in the name, it's crap.
What my avatar is about: https://addons.mozilla.org/en-US/seamonkey/addon/sea-fox/
User avatar
KLB
Posts: 2282
Joined: December 21st, 2003, 9:25 am
Location: Saco Maine
Contact:

Re: Firefox nightly theme changes

Post by KLB »

Until the links are fixed, ust replease the link bug number with the listed bug number.

It looks like the biggest theme impact so far is coming from bug 634065
Ken Barbalace - AMO Editor (I focus on reviewing themes)
I maintain Classic Compact, a very compact yet clean Firefox theme.
EnvironmentalChemistry.com (Periodic Table)
User avatar
patrickjdempsey
Posts: 23686
Joined: October 23rd, 2008, 11:43 am
Location: Asheville NC
Contact:

Re: Firefox nightly theme changes

Post by patrickjdempsey »

I hope mcdavis or someone else can figure out a way to TEST all of the variations of the new identity block. It would be really easy to accidentally pass up.
Tip of the day: If it has "toolbar" in the name, it's crap.
What my avatar is about: https://addons.mozilla.org/en-US/seamonkey/addon/sea-fox/
User avatar
akayser
Posts: 299
Joined: August 25th, 2010, 12:44 am

Re: Firefox nightly theme changes

Post by akayser »

Only some removal of something that never really worked:
Bug 524091 - Remove microsummaries support. Seldom used, undiscoverable and unmaintained.
Creator of the LittleFox, LittleBird, MicroFox, MicroBird, Nautipolis, Walnut, Walnut2, Bricks and Metal themes for Firefox and Thunderbird.
Visit https://addons.mozilla.org/en-US/firefox/addon/123/developers. Mozilla contributor since October 1999 (Mozilla M10).
User avatar
akayser
Posts: 299
Joined: August 25th, 2010, 12:44 am

Re: Firefox nightly theme changes

Post by akayser »

Officially no theme changes, but the formatting of the about:memory page changed:
Bug 633653 - (revampaboutmemory) revamp about:memory

P.s., as noted elsewhere also the About dialog for the Aurora, Beta and Nightly releases has changed also, as it now includes a 'Channel Selector' and a very dark background image, with white text.
So, you will have to check and possibly update your themes for this also.
Creator of the LittleFox, LittleBird, MicroFox, MicroBird, Nautipolis, Walnut, Walnut2, Bricks and Metal themes for Firefox and Thunderbird.
Visit https://addons.mozilla.org/en-US/firefox/addon/123/developers. Mozilla contributor since October 1999 (Mozilla M10).
User avatar
KLB
Posts: 2282
Joined: December 21st, 2003, 9:25 am
Location: Saco Maine
Contact:

Re: Firefox nightly theme changes

Post by KLB »

@akayser,

I've noticed a change in the way Firefox moves tabs into the title bar when maximized. Can you please tell me what changed and what the bug number is for this change? It is breaking one of my theme options and I need to find a fix.
Ken Barbalace - AMO Editor (I focus on reviewing themes)
I maintain Classic Compact, a very compact yet clean Firefox theme.
EnvironmentalChemistry.com (Periodic Table)
User avatar
Paenglab
Posts: 206
Joined: December 30th, 2006, 2:20 am
Location: Switzerland

Re: Firefox nightly theme changes

Post by Paenglab »

@KLB,

Maybe it's Bug 625367
Nuvola theme for Firefox and Thunderbird
User avatar
KLB
Posts: 2282
Joined: December 21st, 2003, 9:25 am
Location: Saco Maine
Contact:

Re: Firefox nightly theme changes

Post by KLB »

Paenglab wrote:@KLB,

Maybe it's Bug 625367

Thanks!

It does appear that this was the likely culprit. As I suspected, they changed the way they do the math to set the negative bottom margin on the title bar to move tabs into the title bar. As a result, when my theme & extension put tabs in title bar, even when the browser window is not maximized, the new calculations set the title bar bottom margin to zero. This caused the tabs to move out of the title bar when tabs were maximized. I think I have a fix, for this, it just needs to be fully tested.
Ken Barbalace - AMO Editor (I focus on reviewing themes)
I maintain Classic Compact, a very compact yet clean Firefox theme.
EnvironmentalChemistry.com (Periodic Table)
User avatar
mcdavis
Posts: 3195
Joined: December 9th, 2005, 5:51 am

Re: Firefox nightly theme changes

Post by mcdavis »

Could we get this thread pinned, please? It's just as important as the already-pinned "Mozilla 2.0 / Firefox 4.0 theme changes" thread.
Theme Development is Radical Participation.
NNL Beta Builds for Current and Up-coming Firefox
Dear User: Your Help is Needed
User avatar
akayser
Posts: 299
Joined: August 25th, 2010, 12:44 am

Re: Firefox nightly theme changes

Post by akayser »

Bug 635402 - Get rid of :not([inFullscreen]) workaround selectors for sizemode transitions
Creator of the LittleFox, LittleBird, MicroFox, MicroBird, Nautipolis, Walnut, Walnut2, Bricks and Metal themes for Firefox and Thunderbird.
Visit https://addons.mozilla.org/en-US/firefox/addon/123/developers. Mozilla contributor since October 1999 (Mozilla M10).
User avatar
akayser
Posts: 299
Joined: August 25th, 2010, 12:44 am

Re: Firefox nightly theme changes

Post by akayser »

This has been checked in without the styling, but one could opt to do something special on the '.chromeUI' class on the identity-box:
Bug 590206 - Make the site identity UI display something sensible for about: and chrome: uris
Creator of the LittleFox, LittleBird, MicroFox, MicroBird, Nautipolis, Walnut, Walnut2, Bricks and Metal themes for Firefox and Thunderbird.
Visit https://addons.mozilla.org/en-US/firefox/addon/123/developers. Mozilla contributor since October 1999 (Mozilla M10).
User avatar
akayser
Posts: 299
Joined: August 25th, 2010, 12:44 am

Re: Firefox nightly theme changes

Post by akayser »

A couple of cosmetic changes:
Bug 657262 - Use ThreeDShadow instead of ThreeDDarkShadow for the border for the location bar and search box in Windows Classic. r=dao
Bug 655691 - Use native button appearance for colorpicker buttons. r=dao
Bug 652447 - Straighten out the weirdness of Pinstripe's livemark-item.png and livemarkItem.png, r=dao
Bug 633282 - Apply moz-win-exclude-glass in browser.xul. r=dao.
Bug 655588 - Desaturating filter produces more realistic grey scale than colour averaging r=Unfocused
Creator of the LittleFox, LittleBird, MicroFox, MicroBird, Nautipolis, Walnut, Walnut2, Bricks and Metal themes for Firefox and Thunderbird.
Visit https://addons.mozilla.org/en-US/firefox/addon/123/developers. Mozilla contributor since October 1999 (Mozilla M10).
User avatar
KLB
Posts: 2282
Joined: December 21st, 2003, 9:25 am
Location: Saco Maine
Contact:

Re: Firefox nightly theme changes

Post by KLB »

akayser wrote:Bug 634065 - Implement design for identity block and persistent indicators

Has anyone come up with a way to test our themes against these changes?
Ken Barbalace - AMO Editor (I focus on reviewing themes)
I maintain Classic Compact, a very compact yet clean Firefox theme.
EnvironmentalChemistry.com (Periodic Table)
User avatar
akayser
Posts: 299
Joined: August 25th, 2010, 12:44 am

Re: Firefox nightly theme changes

Post by akayser »

Bug 656269 - Add link to Mozilla plugin check from Add-ons Manager.
Bug 573176 - Implement Site-Specific Privacy Preferences.

As for bug 634065, I use http://channy.creation.net/project/fire ... ation.html to test the identity block.
Creator of the LittleFox, LittleBird, MicroFox, MicroBird, Nautipolis, Walnut, Walnut2, Bricks and Metal themes for Firefox and Thunderbird.
Visit https://addons.mozilla.org/en-US/firefox/addon/123/developers. Mozilla contributor since October 1999 (Mozilla M10).
Post Reply