MozillaZine

Fx11 Media Fullscreen is breaking for some themes.

Discuss application theming and theme development.
patrickjdempsey

User avatar
 
Posts: 23734
Joined: October 23rd, 2008, 11:43 am
Location: Asheville NC

Post Posted February 5th, 2012, 3:39 am

Something in Aurora is making Themes break the media full-screen button. If the window is non-maximized fullscreen is failing to properly initiate and showing a white background with the previous window shown in the middle. F11 is the only way to back out.

I tested several themes marked as compatible with 11:

Stratini Super - fails (does support full-screen button)
Nasa Night Launch - fails (no full-screen button support yet)
LavaFox V1 - fails (no full-screen button support yet)
Classic Compact - fails (does support full-screen button)

Walnut - works (does support full-screen button)
FT Deep Dark - works (does support full-screen button)
Firefox 3 theme for Firefox 4+ - works (no full-screen button support yet)
MX3 - works (does support full-screen button)

Should a theme even be able to break this? and if so... why?

I went ahead and filed a bug on this: https://bugzilla.mozilla.org/show_bug.cgi?id=724354
Tip of the day: If it has "toolbar" in the name, it's crap.
What my avatar is about: https://addons.mozilla.org/en-US/seamonkey/addon/sea-fox/

KLB

User avatar
 
Posts: 2282
Joined: December 21st, 2003, 9:25 am
Location: Saco Maine

Post Posted February 5th, 2012, 9:26 am

As I posted on the bug, we need more specific steps to reproduce this bug. I wasn't clear on how to reproduce this bug and I could not trip it up using FF11 on WinXP using my theme Classic Compact.
Ken Barbalace - AMO Editor (I focus on reviewing themes)
I maintain Classic Compact, a very compact yet clean Firefox theme.
EnvironmentalChemistry.com (Periodic Table)

patrickjdempsey

User avatar
 
Posts: 23734
Joined: October 23rd, 2008, 11:43 am
Location: Asheville NC

Post Posted February 5th, 2012, 2:10 pm

No pattern for me, it's 100% reproducible in all configurations with a new profile with all extensions and plugins disabled.
Tip of the day: If it has "toolbar" in the name, it's crap.
What my avatar is about: https://addons.mozilla.org/en-US/seamonkey/addon/sea-fox/

KLB

User avatar
 
Posts: 2282
Joined: December 21st, 2003, 9:25 am
Location: Saco Maine

Post Posted February 5th, 2012, 2:52 pm

How are you going into full screen mode? I honestly couldn't replicate it on Classic Compact. I haven't tried other themes, as I first want to make sure I'm doing it right. Also, which version of Windows are you running? This easily could be limited to a specific OS flavor.
Ken Barbalace - AMO Editor (I focus on reviewing themes)
I maintain Classic Compact, a very compact yet clean Firefox theme.
EnvironmentalChemistry.com (Periodic Table)

patrickjdempsey

User avatar
 
Posts: 23734
Joined: October 23rd, 2008, 11:43 am
Location: Asheville NC

Post Posted February 5th, 2012, 3:39 pm

Clicking the media fullscreen button in the player. This is only present in 11 and up.
Tip of the day: If it has "toolbar" in the name, it's crap.
What my avatar is about: https://addons.mozilla.org/en-US/seamonkey/addon/sea-fox/

KLB

User avatar
 
Posts: 2282
Joined: December 21st, 2003, 9:25 am
Location: Saco Maine

Post Posted February 5th, 2012, 8:57 pm

I can not replicate this on Windows XP. I also have not been able replicate it on Win7 running within Virtual Box. Do you have aero support enabled on Win7?
Ken Barbalace - AMO Editor (I focus on reviewing themes)
I maintain Classic Compact, a very compact yet clean Firefox theme.
EnvironmentalChemistry.com (Periodic Table)

patrickjdempsey

User avatar
 
Posts: 23734
Joined: October 23rd, 2008, 11:43 am
Location: Asheville NC

Post Posted February 5th, 2012, 9:21 pm

It was happening in both Aero and Classic mode but I can try more testing tomorrow.
Tip of the day: If it has "toolbar" in the name, it's crap.
What my avatar is about: https://addons.mozilla.org/en-US/seamonkey/addon/sea-fox/

patrickjdempsey

User avatar
 
Posts: 23734
Joined: October 23rd, 2008, 11:43 am
Location: Asheville NC

Post Posted February 6th, 2012, 12:45 am

OK, tested and confirmed, only happens in Aero. Have tried in Basic and Classic and it does not happen.... only in Aero and changing Firefox settings does not help.
Tip of the day: If it has "toolbar" in the name, it's crap.
What my avatar is about: https://addons.mozilla.org/en-US/seamonkey/addon/sea-fox/

mcdavis

User avatar
 
Posts: 3195
Joined: December 9th, 2005, 5:51 am

Post Posted February 16th, 2012, 2:20 am

Try something like this (only when on Windows with Aero, with whatever your theme uses for a background color instead of #181818) and see if it makes things any better:

Code: Select all
#main-window {
  -moz-appearance: none !important;
/* 
  background: none !important;
*/
  background: #181818 !important;
}
#main-window:not([inFullscreen="true"]) {
  -moz-appearance: -moz-win-borderless-glass !important;
  background: none !important;
}


I was having the problem (only when the Firefox button was showing; it worked fine if I was showing the menubar) but the above code in Stylish made video fullscreen start working and render correctly. In other words, make sure the window isn't transparent and has a background for fullscreen video.

Note that those are *not* the selectors I'm using in-theme right now. (The sense is reversed, taking [inFullscreen="true"] as the exception to default styling, as opposed to taking :not([inFullscreen="true"]) as the exception.) That was just a quick attempt at a fix. If no one's shot it down by tomorrow, I'll see if it still makes sense in the light of day.
Theme Development is Radical Participation.
NNL Beta Builds for Current and Up-coming Firefox
Dear User: Your Help is Needed

patrickjdempsey

User avatar
 
Posts: 23734
Joined: October 23rd, 2008, 11:43 am
Location: Asheville NC

Post Posted February 16th, 2012, 3:34 am

Confirmed, this does fix the issue. This is the minimum code needed to fix, it needs to be somewhere *after* the bit where you make the main-window transparent in order to support the Aero titlebar:

Code: Select all
@media all and (-moz-windows-compositor) {
  /* Make HTML5 video transition to Fullscreen mode seamlessly in Firefox 11+ */
  #main-window[inFullscreen="true"] {
    -moz-appearance: none;
     background-color: -moz-dialog!important;
  }
}


[-( Stupid glass.

Thank you mcdavis for finding the solution!!!!
Tip of the day: If it has "toolbar" in the name, it's crap.
What my avatar is about: https://addons.mozilla.org/en-US/seamonkey/addon/sea-fox/

mcdavis

User avatar
 
Posts: 3195
Joined: December 9th, 2005, 5:51 am

Post Posted February 16th, 2012, 2:17 pm

patrickjdempsey wrote:[-( Stupid glass.


I got into this to have fun with smart creative people and do my part to help Mozilla in its mission. I just can't believe some of the **** this has gotten us into.

http://mcdavis.dreamhosters.com/lookatw ... ougive.png

(If it weren't hard it wouldn't be worth doing, but we're definitely not in Kansas any more.)

Thanks for confirming. :)
Theme Development is Radical Participation.
NNL Beta Builds for Current and Up-coming Firefox
Dear User: Your Help is Needed

patrickjdempsey

User avatar
 
Posts: 23734
Joined: October 23rd, 2008, 11:43 am
Location: Asheville NC

Post Posted February 16th, 2012, 3:21 pm

mcdavis wrote:(If it weren't hard it wouldn't be worth doing, but we're definitely not in Kansas any more.)


And if you've been considering taking a sigh and a break, Australis is on the way next.... which is to be something on the order of magnitude of a full transformation of the Firefox UI.
Tip of the day: If it has "toolbar" in the name, it's crap.
What my avatar is about: https://addons.mozilla.org/en-US/seamonkey/addon/sea-fox/

mcdavis

User avatar
 
Posts: 3195
Joined: December 9th, 2005, 5:51 am

Post Posted February 16th, 2012, 7:42 pm

Let's hope things tend toward the middle-right side of the graph.

http://en.wikipedia.org/wiki/Flow_%28ps ... s_for_flow
Theme Development is Radical Participation.
NNL Beta Builds for Current and Up-coming Firefox
Dear User: Your Help is Needed

Return to Theme Development


Who is online

Users browsing this forum: No registered users and 0 guests