Firefox nightly theme changes

[akayser]

Australis
Bug 958089 - Linux still has top padding in customize mode
Bug 960043 - Update quit icon on the menu panel to make it more clear that it will quit the browser
Bug 944947 - Label truncation is not fully supported in Australis menu widgets
Bug 888601 - Panorama (Tab Groups) icon needed in proper sizes
Bug 922834 - Australis: Need a more high-res version of the bookmarks toolbar item placeholder icon for the palette/panel
Bug 875479 - Australis toolbar buttons for Linux
Bug 944138 - [Australis] Remove secondary hover state from combined panel buttons (e.g. cut/copy/paste)
Bug 932947 - [Australis] Mouse-down style for buttons in customization mode

IMHO, The Australis code is very messy code, and trying to do things completely different from any standards...

[patrickjdempsey]

Yup, they've taken the opportunity to clean out a decade of cobbled-together code and simplify it and made it worse.

[akayser]

Bug 962220 - Tabs briefly draw at top of window during customize mode transition
Bug 942144 - Australis - Legacy button not positioned correctly in Australis panel
Bug 900428 - Button labels in the panel menu are too small

[akayser]

Bug 956488 - Add separators to menu panel footer
Bug 869500 - Customization mode should have a favicon (adds: chrome://browser/skin/customizableui/customizeFavicon.ico)
Bug 962620 - Don't set the font size for buttons in the menu panel to what it would be anyway with no font-size specified (removing font-size:1em)

[akayser]

Devtools
Bug 939783 - console.trace() group traces even if part of trace is different

Australis
Bug 941910 - Placeholders in the panel aren't aligned correctly wrt other buttons (so neither are animated icons when dragging)
Bug 940286 - Australis bookmarks menu does not highlight on typing
Bug 878546 - refresh the styling of sub-views
Bug 962150 - Arrow panel box-shadow is cut off at the bottom and right side.

Toolkit
Bug 963008 - msgIdentity has no space between email address and account name

[akayser]

Bug 960528 - Remove the dashed border around items in the downloads library
Bug 957436 - Panel or notification for first fxa-based sync
Bug 940307 - Australis panel does not properly support type="menu-button" style buttons

[akayser]

Australis
Bug 964204 - Customization Mode: Glitch when moving items in the toolbar or the panel
Bug 964322 - Hide grid texture behind panel container during customize mode transition
Bug 962855 - Scroll bar shown in panelUI with default set on Windows, Linux, Mac

[akayser]

Australis
Bug 940093 - Offer UI pref to toggle titlebar back on
Bug 964217 - Search item is broken in customization mode
Bug 947915 - When placed on glass Sync button has wrong (dummy) icon while syncing
Bug 963095 - Widgets with a panel placed in a toolbar are styled incorrectly
Bug 964929 - prompt user to sign-in again UI
Bug 957460 - Firefox Accounts widget for customization panel
Bug 962844 - urlbar with EV SSL overlaps searchbar in narrow window

[mcdavis]

Bug 941781 - Upgrade CodeMirror to 3.20

patch:
- (2013-11-22) (Fx28) https://hg.mozilla.org/mozilla-central/rev/a8c95597f367 (content/codemirror.css, etc.)

There's no in-theme change per se, because CodeMirror styling comes from in-content CSS, but I had to change some rules for this.

[akayser]

Australis
Bug 966511 - Strings review changes and polish
Bug 966546 - Doorhanger should slide and have the right anchor position
Bug 964887 - Bookmark submenu says "Bookmark this page" even for bookmarked pages
Bug 958645 - Scaling effect in customization view doesn't work on some icons.
Bug 932235 - new email link icon
Bug 965820 - margin issues on search field dragged into menu
Bug 962677 - Use content-deck and toolbar margins for the customize mode transition

Devtools
Bug 945547 - Selected tab has wrong text-shadow with lightweight themes applied
Bug 966199 - There's a bit of redundancy and inconsistency in the breadcrumbs styles
Bug 966275 - DevTools Themes[/url] - Change color of main devtools splitter to better match both themes
Bug 965985 - DevTools light theme button followup
Bug 966266 - Remove text shadow from DevTools sidebar tabs

[akayser]

Bug 965772 - search text box changes size when opening a new tab (followup of bug 962844)

[mcdavis]

Bug 862558 - Web Console should always be available / visible

patch:
- (2013-11-19) (Fx28) https://hg.mozilla.org/mozilla-central/rev/7eaa1a0d3fe1 (debugger-panes.js, toolbox.js, toolbox.xul, Tooltip.js, etc.)

There's no in-theme file touched by this patch, but it's a major change for devtools, letting you open the webconsole at the same time as any other devtool, in a pane below the first devtool.

To test: open any devtool other than the Web Console, e.g., HTML Inspector, then press ESC to open a secondary pane showing the Web Console. Press ESC again to close it.

[akayser]

Devtools
Bug 946601 - Add performance statistics/piecharts in the Network Monitor
Bug 952277 - Highlight and jump to nodes from the Debugger
Bug 966601 - Element classes in the breadcrumbs should be colored differently than tag names
Bug 966640 - The right margin of the side menu widget should match the new splitter color on the dark theme
Bug 966639 - The search output panel should use theme colors
Bug 950915 - Watch for changes to CSS files on disk for source mapped files

Australis
Bug 966799 - Bookmark bar text doesn't change color on hover

(one can see that a version release is coming up real soon, given the increase of theme patches)

[mcdavis]

Bug 889638 - Inspector should have a doorhanger with a colorpicker for editing CSS colors

patch:
- (2013-11-17) (Fx28) https://hg.mozilla.org/mozilla-central/rev/6709808f07d8 (spectrum-frame.xhtml, spectrum.css, common.inc.css => common.css, arrow-horizontal-dark.png, arrow-horizontal-dark@2x.png, arrow-horizontal-light.png, arrow-horizontal-light@2x.png, arrow-vertical-dark.png, arrow-vertical-dark@2x.png, arrow-vertical-light.png, arrow-vertical-light@2x.png, etc.)

outcome:
- platform: fx28 and up, all desktop
- creates a new color-picker widget and uses it with color swatches in the HTML Inspector Rules View
- spectrum.js: "creates a color picker widget in any container you give it"
- new devtools-specific arrowpanel arrow images
- there's new CSS, but most of it's in content/spectrum.css, with some in common.css
- stops using different DOM (formerly xul:tooltip) for .devtools-tooltip popups for linux vs. other platforms; now all use arrowpanel

Code: Select all

    panel.devtools-tooltip.theme-tooltip-panel[type="arrow"]
      box.panel-arrowcontainer
        box.panel-arrowbox
          image.panel-arrow
        box.panel-arrowcontent
          // payload
          iframe.devtools-tooltip-iframe[src="chrome://browser/content/devtools/spectrum-frame.xhtml"]
            #document
              html
                head [+]
                body
                  div#spectrum
                    div.spectrum-container.spectrum-show
                      div.spectrum-top
                        div.spectrum-fill
                        div.spectrum-top-inner
                          div.spectrum-color.spectrum-box
                            div.spectrum-sat
                              div.spectrum-val
                                div.spectrum-dragger
                          div.spectrum-hue.spectrum-box
                            div.spectrum-slider.spectrum-slider-control
                      div.spectrum-alpha.spectrum-checker.spectrum-box
                        div.spectrum-alpha-inner
                          div.spectrum-alpha-handle.spectrum-slider-control
          // end payload
          box.panel-inner-arrowcontentfooter

- to test:
-- open any page with CSS that sets a color e.g., http://home.comcast.net/~username54321/ ... index.html
-- inspect any element which has a color set on it, e.g. body for the nnl page
-- go to the rules tab
-- click the color swatch in the rule

[akayser]

Australis
Bug 970511 Allow users to undo the "restore default" action
Bug 969376 [Australis] Make it easier to hit the menu button (apply Fitts' law)
Bug 964104 Icon moves when activating toolbar buttons that show panels
Bug 967836 The titlebar is too short when using an lw-theme on OS X with tabs in titlebar disabled
Bug 964267 Pressing the bookmark menu button also depresses the bookmark star icon
Bug 970380 SDK buttons still look broken inside the menu

Devtools
Bug 969426 DevTools Themes: The strikethrough color in rule view is too dark in the light theme
Bug 964263 Unused blankspace in css computed-view when resizing the sidebar
Bug 971186 Hover state on tabs in .devtools-sidebar-tabs doesn't work properly
Bug 970814 The network monitor's footer buttons (for sorting, clear, etc.) should use theme colors
Bug 899727 Increase maximum size of response panel in network panel
Bug 969448 Netmonitor selected filter reset to "All" upon every new page request.
Bug 969429 DevTools Themes: in the light theme, the sidebar tab separators are too dark

OS/2
Bug 969757 Remove the dead code in our tree which pretends to support OS/2