MozillaZine

The Official Win32 20151014 builds are out

Discussion about official Mozilla Firefox builds
Josa
 
Posts: 4152
Joined: July 28th, 2009, 4:52 pm

Post Posted October 13th, 2015, 3:34 pm

Previous Nightly Builds thread 20151013 | Nightly Build thread RSS feed (courtesy DaCypher)

The Official Win32 20151014 NIGHTLY build is out
The Official Win32 20151014 AURORA build is out
.The Official Firefox 42 Beta 7 builds are not yet out


Previous NIGHTLY: 20151013 (Fx44.0a1)
Previous AURORA: 20151013 (Fx43.0a2)
Previous BETA: 20151013 (Fx42.0b6)

Hourly NIGHTLY builds: mozilla-central-linux | mozilla-central-macosx | mozilla-central-win32 | Firefox Tinderbox | NIGHTLY Changelog
AURORA Tinderbox | AURORA changelog

Fixed:
    NIGHTLY +1
  1. #1203803 [Core:DOM: IndexedDB]-Intermittent Assertion failure: IsOnBackgroundThread(), at /builds/slave/m-in-lx-d-00000000000000000000/build/src/ipc/glue/BackgroundImpl.cpp:199 during stage-package [All][]

Partial Landings/Diagnostic Patches:
    None


    AURORA +11
  1. #1199430
  2. #1211337 [Core:Audio/Video: MSG/cubeb/GMP]-[GMP] Add more crash-report annotations to track sync-shutdown activity [Uns][]
  3. #1208953 [Core:Audio/Video: Playback]-Bandcamp.com audio playback stalls when seeking [All][]
  4. #1213391 [Core:DOM]-Possible GC/CC hole in Promise code [Uns][]
  5. #1179397 [Core:DOM: Service Workers]-Assert/Crash running "fetch-event-async-respond-with.https.html" wpt service worker test in Nightly [All][]
  6. #1207041 [Core:Graphics: Layers]-https://loop.ableton.com/participants/ gets blanked out [Uns][]
  7. #1176929 [Core:Widget: Gtk]-[GTK3.14/3.16] ctrl+k shortcut does not give focus to the search field [Lin][]
  8. #1210430 [Firefox:Developer Tools: Framework]-Beta Doorhanger DevTools popup doesn't work [Uns][]
  9. #1203253 [Firefox:Preferences]-Add back/port the tests that got removed from bug 1140495 [Uns][]
  10. #1205677 [Firefox:Theme]-Set --toolbarbutton-checkedhover-backgroundcolor to something reasonable for Windows 8 and 10 [Win][]
  11. #1194706 [Hello (Loop):Client]-Sharing controls no longer shown on detached Hello window [Uns][[sharing defect]]
    BETA +4
  1. #1199430
  2. #1208665
  3. #1212669
  4. #1208953 [Core:Audio/Video: Playback]-Bandcamp.com audio playback stalls when seeking [All][]

Nightly 44.0 fixes since 20150921 (Gecko 43) ~976
Aurora 43.0 fixes since 20150810 (Gecko 42) ~1921
Beta 42.0 fixes since 20150630 (Gecko 41) ~2385

Release tracking Firefox 42-44 see HERE
Last edited by Josa on October 14th, 2015, 10:31 am, edited 1 time in total.

WildcatRay

User avatar
 
Posts: 7467
Joined: October 18th, 2007, 7:03 pm
Location: Columbus, OH

Post Posted October 13th, 2015, 4:16 pm

With today's NIghtly, I am seeing some very small icons on toolbar buttons. Specifically, the History and Bookmarks buttons with dropdown menus on the left that are Nightly buttons and Extensions Options Menu between the Pocket and Kaspersky buttons on the right.
Image
Only extensions installed are Kaspersky, CTR and EOM. Disabling CTR does not "correct" the issue.

I suspect the landing of Bug #1208715 [Firefox:Theme]-Impose size restriction on extension icons [Uns] may be the source of the issue.

Anyone else seeing similar?
Ray

OS'es: 4 computers with Win10 Pro 64-bit; Current Firefox, Beta, Nightly, Chrome, Vivaldi

TheVisitor
 
Posts: 4990
Joined: May 13th, 2012, 10:43 am

Post Posted October 13th, 2015, 5:17 pm

@WildcatRay

Icons look normal here...

WildcatRay

User avatar
 
Posts: 7467
Joined: October 18th, 2007, 7:03 pm
Location: Columbus, OH

Post Posted October 13th, 2015, 5:29 pm

TheVisitor wrote:@WildcatRay

Icons look normal here...

Not all button icons are affected. (In my image, I am using CTR to go to small icons, but disabling it had no effect on the affected buttons in my posted image.)
Ray

OS'es: 4 computers with Win10 Pro 64-bit; Current Firefox, Beta, Nightly, Chrome, Vivaldi

Chris000001
 
Posts: 458
Joined: September 12th, 2005, 4:43 pm

Post Posted October 13th, 2015, 6:33 pm

Extensions that use buttons of type="menu" have those super small icons. type="menu-button" is fine.

Frank Lion

User avatar
 
Posts: 20472
Joined: April 23rd, 2004, 6:59 pm
Location: ... The Exorcist....United Kingdom

Post Posted October 13th, 2015, 7:13 pm

WildcatRay wrote:
TheVisitor wrote:@WildcatRay

Icons look normal here...

Not all button icons are affected. (In my image, I am using CTR to go to small icons, but disabling it had no effect on the affected buttons in my posted image.)

I remember that I fixed this one a good while back, but it was on an earlier bug than 2015-09-26 that was trying to do the same thing.

Advise Aris to look at the Diff on that bug and then use unset !important; for the stuff that they have put max-width/height on, the buttons then obey the size rules the theme/ext gives them.

Bad bug that, absolutely wrecks buttons on third party themes. Luckily, I caught it long before it hit a Release version.
Metal Lion latest SeaMonkey & Thunderbird Themes - Sea Monkey and Silver Sea Monkey
"The only thing necessary for the triumph of evil, is for good men to do nothing." - Edmund Burke (attrib.)

WildcatRay

User avatar
 
Posts: 7467
Joined: October 18th, 2007, 7:03 pm
Location: Columbus, OH

Post Posted October 13th, 2015, 7:18 pm

Frank Lion wrote:I remember that I fixed this one a good while back, but it was on an earlier bug than 2015-09-26 that was trying to do the same thing.

Advise Aris to look at the Diff on that bug and then use unset !important; for the stuff that they have put max-width/height on, the buttons then obey the size rules the theme/ext gives them.

First, it is not a CTR issue. When CTR is disabled, not switched to default large, the issue still exists. (I only mention it because of using CTR to use small buttons in the image I posted.)
Ray

OS'es: 4 computers with Win10 Pro 64-bit; Current Firefox, Beta, Nightly, Chrome, Vivaldi

Frank Lion

User avatar
 
Posts: 20472
Joined: April 23rd, 2004, 6:59 pm
Location: ... The Exorcist....United Kingdom

Post Posted October 13th, 2015, 7:21 pm

WildcatRay wrote:First, it is not a CTR issue.

Second, I know -

Bad bug that, absolutely wrecks buttons on third party themes. Luckily, I caught it long before it hit a Release version.


I just figured that you, in particular, would be most concerned about CTR, that's all.
Metal Lion latest SeaMonkey & Thunderbird Themes - Sea Monkey and Silver Sea Monkey
"The only thing necessary for the triumph of evil, is for good men to do nothing." - Edmund Burke (attrib.)

WildcatRay

User avatar
 
Posts: 7467
Joined: October 18th, 2007, 7:03 pm
Location: Columbus, OH

Post Posted October 14th, 2015, 2:31 am

No, I am most concerned with a poorly executed patch that was not checked for all its ramifications before being applied.
Ray

OS'es: 4 computers with Win10 Pro 64-bit; Current Firefox, Beta, Nightly, Chrome, Vivaldi

Frank Lion

User avatar
 
Posts: 20472
Joined: April 23rd, 2004, 6:59 pm
Location: ... The Exorcist....United Kingdom

Post Posted October 14th, 2015, 2:56 am

WildcatRay wrote:No, I am most concerned with a poorly executed patch that was not checked for all its ramifications before being applied.

They checked it alright, they just didn't care what it did so long as default was OK.

https://bugzilla.mozilla.org/show_bug.cgi?id=1208715#c7

I wasn't amongst those 'few vocal add-on authors' back then, I just fixed it my end. But you only have to glance at the Diff, then and now, to know that such generalised scatter gun rules will break anything it looks at. Pretty obviously many third party themes, for example, use toolbar button larger than the tiny default ones.

The entire bug seems to be about just one ext author who used a 32x32 button (because the date couldn't be read by anyone without 20/20 vision otherwise?) - https://bug1208715.bmoattachments.org/a ... id=8666329

Considering that all extensions now need to be signed, wouldn't it have been easier just to instruct AMO to reject exts that use larger buttons for no real reason? The above use seems reasonable to me.
Metal Lion latest SeaMonkey & Thunderbird Themes - Sea Monkey and Silver Sea Monkey
"The only thing necessary for the triumph of evil, is for good men to do nothing." - Edmund Burke (attrib.)

dao-g
 
Posts: 670
Joined: January 31st, 2005, 5:37 am
Location: Berlin

Post Posted October 14th, 2015, 3:36 am

WildcatRay wrote:No, I am most concerned with a poorly executed patch that was not checked for all its ramifications before being applied.

You're using Nightly builds, things can break. This is neither a big deal in this particular case nor should it generally surprise you. I've posted a patch in bug 1214555 to fix the regression. Business as usual.

Frank Lion

User avatar
 
Posts: 20472
Joined: April 23rd, 2004, 6:59 pm
Location: ... The Exorcist....United Kingdom

Post Posted October 14th, 2015, 3:59 am

dao-g wrote:things can break. This is neither a big deal in this particular case

The big deal, Dao, is that you must have known that stuff would break as soon as you coded that?

You going to fix this 'regression' now as well? -

Code: Select all
.toolbarbutton-1 > .toolbarbutton-icon,
.toolbarbutton-1 > :-moz-any(.toolbarbutton-menubutton-button, .toolbarbutton-badge-stack) > .toolbarbutton-icon {
  max-width: 16px;
}
Metal Lion latest SeaMonkey & Thunderbird Themes - Sea Monkey and Silver Sea Monkey
"The only thing necessary for the triumph of evil, is for good men to do nothing." - Edmund Burke (attrib.)

dao-g
 
Posts: 670
Joined: January 31st, 2005, 5:37 am
Location: Berlin

Post Posted October 14th, 2015, 4:13 am

Frank Lion wrote:
dao-g wrote:things can break. This is neither a big deal in this particular case

The big deal, Dao, is that you must have known that stuff would break as soon as you coded that?

Not sure what you mean by "stuff". I hadn't realized that type="menu" buttons would be busted on Windows.

Frank Lion wrote:You going to fix this 'regression' now as well? -

Code: Select all
.toolbarbutton-1 > .toolbarbutton-icon,
.toolbarbutton-1 > :-moz-any(.toolbarbutton-menubutton-button, .toolbarbutton-badge-stack) > .toolbarbutton-icon {
  max-width: 16px;
}

Probably not, since this was intended.

Frank Lion

User avatar
 
Posts: 20472
Joined: April 23rd, 2004, 6:59 pm
Location: ... The Exorcist....United Kingdom

Post Posted October 14th, 2015, 4:42 am

dao-g wrote:Probably not, since this was intended.

You mean intended in a 'here's a bug about 1 extension in 18,000 using a 32x32 button, therefore I'll fix that by writing this for it - https://bugzilla.mozilla.org/attachment ... ction=diff ' type way?
Metal Lion latest SeaMonkey & Thunderbird Themes - Sea Monkey and Silver Sea Monkey
"The only thing necessary for the triumph of evil, is for good men to do nothing." - Edmund Burke (attrib.)

darkred
 
Posts: 227
Joined: March 13th, 2010, 6:10 am

Post Posted October 14th, 2015, 5:46 am

If you use inbounds and Greasemonkey, with todays build, don't install nor update any script, because the scripts will disapppear at Firefor re-launch
(gm_scripts\config.xml gets modified/corrupted when you close Firefox, thus making GM unable to use config.xml anymore).

I just filed: Bug 1214621 - (Greasemonkey) Since inbounds of 14-10-2015, if I install (or update) a script, then scripts disappear in about:addons|User Scripts (the problem is caused by the fact that closing tags are appended to tags that previously self-closed in config.xml)



PS. Maybe some patch has landed related to XML compatibility? (I couldn't find any )
'(Firefox for desktop) list fixed bugs in Mercurial' userscript:
as a list: v4.2.2 and, as a sortable table: either v5.5.4 (for all channel users) or v5.5.4 (especially for inbound users).
My other userscripts: GreasyFork OpenUserJS

Return to Firefox Builds


Who is online

Users browsing this forum: No registered users and 1 guest