Updated file for Stylish that is broken by patch 1254752

Discussion about official Mozilla Firefox builds
Post Reply
User avatar
streetwolf
Posts: 2706
Joined: August 21st, 2011, 8:07 am
Location: NJ (USA)

Updated file for Stylish that is broken by patch 1254752

Post by streetwolf »

I got in contact with Chris who created the patch the broke Stylish and other add-ons. The patch can be found at https://bugzilla.mozilla.org/show_bug.cgi?id=1254752. He gives the changes to be made in the last post for Stylish. Here I've included all the code, with the update, from the file which is called aboutStylishEdit.js. Replace the code in the file with the code below. Stylish is in the Extensions folder and is called {46551EC9-40F0-4e47-8E18-8E5CF550CFB8}.xpi. The file is just a zip file so you can update it in place or copy over one you made.

Hoping Jason B the author updates it officially.

"use strict";

const Cc = Components.classes;
const Ci = Components.interfaces;

Components.utils.import("resource://gre/modules/XPCOMUtils.jsm");

function AboutStylishEdit() { }
AboutStylishEdit.prototype = {
classDescription: "about:stylish-edit",
contractID: "@mozilla.org/network/protocol/about;1?what=stylish-edit",
classID: Components.ID("{3d4ef6d0-548b-11e4-916c-0800200c9a66}"),
QueryInterface: XPCOMUtils.generateQI([Ci.nsIAboutModule]),

getURIFlags: function(aURI) {
return Ci.nsIAboutModule.ALLOW_SCRIPT;
},

newChannel: function(aURI, aLoadInfo) {
let ios = Cc["@mozilla.org/network/io-service;1"].getService(Ci.nsIIOService);
let newURI = ios.newURI("chrome://stylish/content/edit.xul", null, null);
let channel = ios.newChannelFromURIWithLoadInfo(newURI, aLoadInfo);
channel.originalURI = aURI;
return channel;
}
};
const NSGetFactory = XPCOMUtils.generateNSGetFactory([AboutStylishEdit]);
Intel i9-13900K | ASUS ROG MAXIMUS Z790 HERO DDR5 | 64GB CORSAIR VENGEANCE DDR5 @ 6600 Mhz.
H100i ELITE CAPELLIX XT Liquid CPU Cooler | PNY 12GB GeForce RTX 3080 Ti | 2 CORSAIR 2TB MP600 PRO XT GEN 4
HX1200 PLATINUM PSU | XENEON 32" IPS UHD 144Hz | BenQ 32" UHD | MS Windows 11 Pro
User avatar
streetwolf
Posts: 2706
Joined: August 21st, 2011, 8:07 am
Location: NJ (USA)

Re: Updated file for Stylish that is broken by patch 1254752

Post by streetwolf »

If you want the complete xpi file with the changes you can grab it below. Remember the changes were made my Christoph Kerschbaumer and verified as working by me.

http://1drv.ms/24Votbl
Intel i9-13900K | ASUS ROG MAXIMUS Z790 HERO DDR5 | 64GB CORSAIR VENGEANCE DDR5 @ 6600 Mhz.
H100i ELITE CAPELLIX XT Liquid CPU Cooler | PNY 12GB GeForce RTX 3080 Ti | 2 CORSAIR 2TB MP600 PRO XT GEN 4
HX1200 PLATINUM PSU | XENEON 32" IPS UHD 144Hz | BenQ 32" UHD | MS Windows 11 Pro
makondo
Posts: 1961
Joined: October 18th, 2007, 5:26 pm
Location: Rocky Mountains

Re: Updated file for Stylish that is broken by patch 1254752

Post by makondo »

Thanks, got hit with it yesterday. Although can't update edited published styles anyway ...

Image

Custom Buttons is broken too, dead Rclick menu, nothing happens on clicks.
paltus
Posts: 68
Joined: March 2nd, 2014, 1:36 am

Re: Updated file for Stylish that is broken by patch 1254752

Post by paltus »

makondo wrote:Custom Buttons is broken too
https://forum.mozilla-russia.org/viewto ... 07#p710007
Joker1337
Posts: 64
Joined: July 15th, 2012, 2:04 pm

Re: Updated file for Stylish that is broken by patch 1254752

Post by Joker1337 »

streetwolf, open PR on github with these changes.
makondo
Posts: 1961
Joined: October 18th, 2007, 5:26 pm
Location: Rocky Mountains

Re: Updated file for Stylish that is broken by patch 1254752

Post by makondo »

Thanks, paltus, but it's all Esperanto to me. Hopefully Anton will update CB before this hits a release version.
Surprisingly, my other exts. seem to work all right so far.
paltus
Posts: 68
Joined: March 2nd, 2014, 1:36 am

Re: Updated file for Stylish that is broken by patch 1254752

Post by paltus »

makondo
Just open CustomButtonsService.js (firefox_profile_folder\extensions\custombuttons@xsms.org\components\) in text editor, search

Code: Select all

this. channel = ios. newChannel (imageURL, null, null);
replace to

Code: Select all

this. channel = ios. newChannelFromURIWithLoadInfo (ios. newURI (imageURL, null, null), null);
and

Code: Select all

var xulchan = ios. newChannel (uri, null, null);
to

Code: Select all

var xulchan = ios. newChannelFromURIWithLoadInfo (ios. newURI (uri, null, null), null);
makondo
Posts: 1961
Joined: October 18th, 2007, 5:26 pm
Location: Rocky Mountains

Re: Updated file for Stylish that is broken by patch 1254752

Post by makondo »

I see, thanks!

EDIT: actually, Menu Wizard appears broken too, doesn't open Options.

EDIT: the developer posted a test version there, it works.
Last edited by makondo on March 17th, 2016, 10:10 am, edited 1 time in total.
paltus
Posts: 68
Joined: March 2nd, 2014, 1:36 am

Re: Updated file for Stylish that is broken by patch 1254752

Post by paltus »

Same, as with Stylish. Unpack xpi file, open s3menuwizard.js, search

Code: Select all

	'aboutPage' : {
		QueryInterface: XPCOMUtils.generateQI([Components.interfaces.nsIAboutModule]),
		getURIFlags: function(aURI) {
			return Components.interfaces.nsIAboutModule.ALLOW_SCRIPT;
		},
		newChannel: function(aURI) {
			let uri = Services.io.newURI("chrome://s3menuwizard/content/settings.xul", null, null);
			let chan = Services.io.newChannelFromURI(uri);
			chan.originalURI = aURI;
			return chan;
		},
		getURIFlags: function(aURI) { 0 }
	}
};
and replace with

Code: Select all

	'aboutPage' : {
		QueryInterface: XPCOMUtils.generateQI([Components.interfaces.nsIAboutModule]),
		getURIFlags: function(aURI) {
			return Components.interfaces.nsIAboutModule.ALLOW_SCRIPT;
		},
		newChannel: function(aURI, aLoadInfo) {
			let ios = Cc["@mozilla.org/network/io-service;1"].getService(Ci.nsIIOService);
			let newURI = ios.newURI("chrome://s3menuwizard/content/settings.xul", null, null);
			let channel = ios.newChannelFromURIWithLoadInfo(newURI, aLoadInfo);
			channel.originalURI = aURI;
			return channel;
		},
		getURIFlags: function(aURI) { 0 }
	}
};
Also, please, report here: [EXT] Menu Wizard
makondo
Posts: 1961
Joined: October 18th, 2007, 5:26 pm
Location: Rocky Mountains

Re: Updated file for Stylish that is broken by patch 1254752

Post by makondo »

I already did. Thanks!
Post Reply