MozillaZine

[ext] Private Tab (no restart)

Announce and Discuss the Latest Theme and Extension Releases.
juozas

User avatar
 
Posts: 53
Joined: November 9th, 2009, 2:55 am

Post Posted January 21st, 2017, 10:36 pm

@FineWine
If using 0.2.1 Install earlier version (0.2.0), then upgrade, or wait for 0.2.1.1. I just reported the bug yesterday, fixed in 0.2.1.1.

Also refer to https://github.com/Infocatcher/Private_ ... leshooting for any upcomming issues.
Сделано в СССР

FineWine

User avatar
 
Posts: 176
Joined: July 16th, 2004, 12:21 am

Post Posted January 21st, 2017, 11:22 pm

juozas wrote:@FineWine
If using 0.2.1 Install earlier version (0.2.0), then upgrade, or wait for 0.2.1.1. I just reported the bug yesterday, fixed in 0.2.1.1.

Thank you for that - now is working.

juozas wrote:Also refer to https://github.com/Infocatcher/Private_ ... leshooting for any upcomming issues.

Yes I do usually do this, I even have a virgin profile & CTR only profile, for just this purpose but it has been a long day for me and it slipped under the radar, I even had to do a bump in the CTR forum for just this question as I had not read the previous entries just above mine. :oops:

Anyway on with the next question: Would it not be easier and nicer for everyone, if the GitHub userstyles icon & underline overlay css code etc be written into the actual extension itself maybe as a 'Preference Pane' selection? If this was done then maybe also add the ability to change the Tab Text colour plus background colour automatically when in Private Tab mode. (I will post that last part in CTR forums as well) Maybe 'infocatcher' & 'Aris' could liaise over this or even TMP+.

Also when you use the default FF 'New Private Window" selector it shows a nice dark purple 'Private Browsing with Tracking Protection' info page, could not the same info page be shown in 'Private Tab' selection as well?

Infocatcher

User avatar
 
Posts: 253
Joined: July 1st, 2007, 3:45 am

Post Posted January 22nd, 2017, 3:47 am

FineWine wrote:Just installed this Add-on but not working in macOS Firefox 50.1.0 with latest CTR (not even appearing as per screen shots) is listed in my extensions though and have restarted.

What am I doing wrong?

This is due to https://github.com/Infocatcher/Private_Tab/issues/240
Will be fixed in Private Tab 0.2.1.1, sorry for inconvenience.
Or workaround: in about:config, New - Integer - extensions.privateTab.prefsVersion - 1 (then will be installed correctly).
This game has no name. It will never be the same. ©

FineWine

User avatar
 
Posts: 176
Joined: July 16th, 2004, 12:21 am

Post Posted January 22nd, 2017, 1:52 pm

Infocatcher wrote:This is due to https://github.com/Infocatcher/Private_Tab/issues/240
Will be fixed in Private Tab 0.2.1.1, sorry for inconvenience.
Or workaround: in about:config, New - Integer - extensions.privateTab.prefsVersion - 1 (then will be installed correctly).


Thanks

Any thoughts on the rest of my post?

Aris of CTR fame has said he will help me with this but it would be nice to have it built right into your ext.

Cheers

FineWine

User avatar
 
Posts: 176
Joined: July 16th, 2004, 12:21 am

Post Posted January 23rd, 2017, 6:32 am

Using code from infocatcher's https://github.com/Infocatcher/Private_Tab#styles and a lot of help from Aris of Classic Theme Restorer fame I now have a Style that adds more functionality to infocatcher's great little extension and achieves the following:

- adds icon to the left of the 'tabbrowser-tab'
- adds icon to PrivateTab File menu item label 'New Private Tab'
- adds icon to PrivateTab Tab context menu item label 'New Private Tab'
- changes selected PrivateTab text to RED
- enables alternately blinking of the Tab icon and text at a rate of 1.5 seconds
- tab text & icon blinks whether selected or not. (Note the icon & text alternately blinks, rather neat really)

I have also experimented with the whole PrivateTab blinking and can provide the code for that but in the end decided on just the text & icon blinking.

Hope you all enjoy - cheers

Code: Select all
 /* AGENT_SHEET */

    /* Perform decorative changes to private tabs, https://addons.mozilla.org/addon/private-tab/ */

    /* Tab icon & text alternately blinks + text color change https://addons.mozilla.org/addon/private-tab/ */
        #main-window #navigator-toolbox #TabsToolbar .tabbrowser-tab[privateTab-isPrivate] :-moz-any(label,.tab-label,.tab-text,.tab-icon-image,.toolbarbutton-icon) {
          animation-name: blinker;
          animation-duration: 1.5s;
          animation-timing-function: linear;
          animation-iteration-count: infinite;
         
          font-weight: bold !important;
          color: #FF0000 !important;
        }

        @keyframes blinker {
          0% { opacity: 1.0; }
          50% { opacity: 0.2; }
          100% { opacity: 1.0; }
    }

    /* Add icons to Private Tab's menu items https://addons.mozilla.org/addon/private-tab/ */
    @-moz-document url("chrome://browser/content/browser.xul"),
       url("chrome://navigator/content/navigator.xul") {
       #privateTab-menu-openNewPrivateTab,
       #privateTab-places-openInNewPrivateTab,
       #privateTab-context-openInNewPrivateTab {
          -moz-binding: url("chrome://global/content/bindings/menu.xml#menuitem-iconic") !important;
          list-style-image: url("chrome://privatetab/content/privacy-16.png") !important;
       }
       #privateTab-menu-openNewPrivateTab > .menu-iconic-left,
       #privateTab-places-openInNewPrivateTab > .menu-iconic-left,
       #privateTab-context-openInNewPrivateTab > .menu-iconic-left {
          -moz-appearance: menuimage !important;
       }
       /* Tab context menu: use mask icon instead of default checkbox image */
       #privateTab-tabContext-toggleTabPrivate > .menu-iconic-left > .menu-iconic-icon {
          display: -moz-box !important;
          list-style-image: url("chrome://privatetab/content/privacy-16.png") !important;
          -moz-image-region: auto !important;
       }
       #privateTab-tabContext-toggleTabPrivate > .menu-iconic-left {
          -moz-appearance: menuimage !important;
          filter: grayscale(1);
          opacity: 0.6 !important;
       }
       #privateTab-tabContext-toggleTabPrivate[checked] > .menu-iconic-left {
          filter: none !important;
          opacity: 1 !important;

       }
         
          /* Add overlay icon to private tabs, https://addons.mozilla.org/addon/private-tab/ */
       /* You should correct margins for your theme... */
       .tabbrowser-tab[privateTab-isPrivate] .tab-content:before {
          /* http://www.iconfinder.com/icondetails/11679/16/clock_small_icon */
          content: url("data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAABAAAAAQCAYAAAAf8/9hAAAAGXRFWHRTb2Z0d2FyZQBBZG9iZSBJbWFnZVJlYWR5ccllPAAAASVJREFUeNpi/P//PwMlgImBQjDwBrCgCwQFBTEwMTEJMTIymgG5ElDhF8CwOvXv379369atw28AUKEQFw9PmE9oaKgQD4+pqoYGw8kzZ05vWb169eePH1cBlbzD64Xfv39bugUEhCtrajptXLOG983Xr7wqWlpOnkFB4SA5gl749euXjIqGhrG0kBDDy5cvGeRFRBj+/PvH8F9T0xgkR9CAHz9+MDMxMjIwMzExvHr1iiEuIoJBQkKCwdnDAyxH0ICfP3++uHHp0kV5CQmbNZs2gcX+ARPb3r17L4LkiHHB4TlTpqhysbIy29jY6IHEjh09emnGpElbQHLo6hnRk7KWlhbDx48fxYH+dQNyFaHC99nY2Hbx8/O/vHbtGn4DRmBeAAgwAJR8fPChrRrjAAAAAElFTkSuQmCC") !important;
          display: -moz-box !important;
          position: relative !important;
          z-index: 2147483647 !important;
          /* Theme-specific: */
          /* start + end = -16 (icon width) */
          -moz-margin-start: 8px !important;
          -moz-margin-end: -24px !important;
          /* top + bottom = 0 */
          margin-top: 4px !important;
          margin-bottom: -4px !important;
       }
       .tabbrowser-tab[privateTab-isPrivate][pinned] .tab-content:before {
          /* Theme-specific: */
          /* start + end = -16 (icon width) */
          -moz-margin-start: 11px !important;
          -moz-margin-end: -27px !important;
      }
         
       /* Add icon to private tabs, https://addons.mozilla.org/addon/private-tab/ */
       .tabbrowser-tab[privateTab-isPrivate] .tab-icon-image,
       .menuitem-iconic[privateTab-isPrivate] .menu-iconic-icon {
          /* Trick: change binding to break "src" attribute */
          -moz-binding: url("chrome://global/content/bindings/toolbarbutton.xml#toolbarbutton") !important;
       }
       .tabbrowser-tab[privateTab-isPrivate] .tab-icon-image > .toolbarbutton-icon,
       .menuitem-iconic[privateTab-isPrivate] .menu-iconic-icon > .toolbarbutton-icon {
          /*list-style-image: url("chrome://browser/skin/privatebrowsing/favicon.svg") !important;*/
          list-style-image: url("chrome://privatetab/content/privacy-16.png") !important;
          display: -moz-box !important;
          width: auto !important;
          height: auto !important;
          margin: 0 !important;
          padding: 0 !important;
          border: none !important;
       }
       .tabbrowser-tab[privateTab-isPrivate] .tab-icon-image > .toolbarbutton-text,
       .tabbrowser-tab[privateTab-isPrivate] .tab-icon-image > .toolbarbutton-multiline-text,
       .menuitem-iconic[privateTab-isPrivate] .menu-iconic-icon > .toolbarbutton-text,
       .menuitem-iconic[privateTab-isPrivate] .menu-iconic-icon > .toolbarbutton-multiline-text {
          display: none !important;
       }
         
        /* Always show tab icon (for Australis) */
       .tabbrowser-tab[privateTab-isPrivate]:not([busy]) .tab-icon-image {
          display: -moz-box !important;
      }   

    }

Grg68

User avatar
 
Posts: 37
Joined: January 21st, 2011, 12:36 pm
Location: Greece, island of Crete, Chania

Post Posted January 23rd, 2017, 5:08 pm

Hi all,

I face a severe issue after i upgraded firefox to v50.
When a private tab is unloaded (manually or automatically), i can't reload it, close it
or select it.
In other words, i can't "touch" it by any means.
I use "Auto Unload Tab", but in my tests in a clean profile, i tried also "UnloadTab" and
"BarTab Heavy" with about the same results.
I noticed also (before a private tab is unloaded) that if i select an already open new
tab, the bookmarks star becomes blue and firefox saves that tab in the last bookmarks
folder i had created a bookmark.
After a private tab is unloaded, there are many side effects and error references in
browser console.
For example, pointing with mouse bookmark folders, their subfolders seems to be
multiplicated to infinity, after restart the unloaded private tabs are survived in some
cases, etc.
The most severe side effect, if i right click on an unloaded private tab and click on
"Close Other Tabs", this causes high cpu rates by the unresponsive script
"chrome://browser/content/tabbrowser.xml:2449" and breaks completely the browser.
After that, its buttons are clickable but do nothing and its menus can be open but
clicking any of submenu items has no any effect. The only thing i can do is to kill the browser.

All the above do not happen in a private window and definitely i had not any of these
issues in firefox 49 and older.
Grg

Infocatcher

User avatar
 
Posts: 253
Joined: July 1st, 2007, 3:45 am

Post Posted January 24th, 2017, 11:29 pm

Grg68 wrote:I face a severe issue after i upgraded firefox to v50.
When a private tab is unloaded (manually or automatically), i can't reload it, close it
or select it.
I'll see. I tried UnloadTab and it's buggy, yes...
Also looks like Suspend Tab (or nightly/suspendtab.xpi) works correct, at least in Firefox 50.
This game has no name. It will never be the same. ©

Grg68

User avatar
 
Posts: 37
Joined: January 21st, 2011, 12:36 pm
Location: Greece, island of Crete, Chania

Post Posted January 25th, 2017, 3:41 pm

Yes, "UnloadTab" is buggy and seems that it has been abandoned. It causes unloaded tabs to
become empty tabs after restart of firefox.
This was mainly the reason i switched to "Auto Unload Tab" and i hadn't any issue before firefox 50.
I suggest you use "Auto Unload Tab" or "BarTab Heavy" during the investigation of this issue of
unloading private tabs, because both of them are maintained by their developers.
Using them in my tests, i noticed that the main issue of unloading private tabs and all other side
effects are slightly different.
I forgot also to mention that sometimes a private tab becomes "unreachable" if i switch to an
other tab before the private tab is loaded completely or if i open several private tabs in the
background by middle-clicking links in a page.
Grg

Infocatcher

User avatar
 
Posts: 253
Joined: July 1st, 2007, 3:45 am

Post Posted January 27th, 2017, 1:21 pm

This game has no name. It will never be the same. ©

Grg68

User avatar
 
Posts: 37
Joined: January 21st, 2011, 12:36 pm
Location: Greece, island of Crete, Chania

Post Posted January 27th, 2017, 4:22 pm

I tried v0.2.1.2 in Mozilla Developer Preview 51, but i still face the same issues..
Below there are some findings in Browser Console:

When i unload a private tab:
Code: Select all
TypeError: privacyContext is null[Learn More]  bootstrap.js:4385:3
TypeError: aBrowser.currentURI is null[Learn More]  browser-thumbnails.js:95:1
   Thumbnails_capture chrome://browser/content/browser-thumbnails.js:95:1
   Thumbnails_delayedCapture/timeout< chrome://browser/content/browser-thumbnails.js:112:7
   bound  self-hosted

When i try to access a unloaded private tab:
Code: Select all
NS_ERROR_FAILURE: Failure arg 0 [nsISecureBrowserUI.init]  browser.xml:781
   get_securityUI chrome://global/content/bindings/browser.xml:781:17
   updateCurrentBrowser chrome://browser/content/tabbrowser.xml:1109:17
   onselect chrome://browser/content/browser.xul:1:44
   set_selectedIndex chrome://global/content/bindings/tabbox.xml:652:13
   set_selectedPanel chrome://global/content/bindings/tabbox.xml:671:13
   set_selectedIndex chrome://global/content/bindings/tabbox.xml:399:15
   set_selectedItem chrome://global/content/bindings/tabbox.xml:431:34
   _selectNewTab chrome://global/content/bindings/tabbox.xml:476:11
   onxblmousedown chrome://global/content/bindings/tabbox.xml:782:11

When i attempt to close a unloaded private tab:
Code: Select all
TypeError: privacyContext is null[Learn More]  bootstrap.js:4385:3
TypeError: can't access dead object  tabbrowser.xml:2431:19
   _beginRemoveTab chrome://browser/content/tabbrowser.xml:2431:19
   removeTab chrome://browser/content/tabbrowser.xml:2306:18
   onxblclick chrome://browser/content/tabbrowser.xml:6363:9

When i attempt to reload a unloaded private tab:
Code: Select all
TypeError: gBrowser.currentURI is null[Learn More]  browser.js:1797:1
   BrowserReload chrome://browser/content/browser.js:1797:1
   BrowserReloadOrDuplicate chrome://browser/content/browser.js:1791:5
   oncommand chrome://browser/content/browser.xul:1:1
Grg

q1k
 
Posts: 21
Joined: June 2nd, 2016, 2:48 pm

Post Posted February 1st, 2017, 6:04 pm

Please provide option to change tab context menu item to be "New Private Tab", instead of converting it to private tab.

i411
New Member
 
Posts: 1
Joined: February 12th, 2017, 2:02 am

Post Posted February 12th, 2017, 2:11 am

hi there,
1st i want to thank you for this great addon
2nd i want to ask you to fix cookies issue, private tab storing cookies like normal mode, in other hand firefox private mode doesnt store any cookies

Infocatcher

User avatar
 
Posts: 253
Joined: July 1st, 2007, 3:45 am

Post Posted May 27th, 2017, 12:50 pm

This game has no name. It will never be the same. ©

Grg68

User avatar
 
Posts: 37
Joined: January 21st, 2011, 12:36 pm
Location: Greece, island of Crete, Chania

Post Posted May 28th, 2017, 5:38 pm

Hi all,
With PT 0.2.2 in firefox 53, i still face the same issues when i unload a private tab, as i describe in
my previous posts.
Additionally, recently i noticed that when i move a private tab to some other window or when i detach
a private tab to create a new window with it, this tab becomes blank and "untouchable", the same
way like an unloaded private tab.
Grg

Infocatcher

User avatar
 
Posts: 253
Joined: July 1st, 2007, 3:45 am

Post Posted June 7th, 2017, 11:32 pm

Bug about API for private tabs in Firefox 57+ was wontfixed:
https://bugzilla.mozilla.org/show_bug.cgi?id=1358058#c12
https://github.com/Infocatcher/Private_Tab/issues/254#issuecomment-307010217
Containers is good idea, but implementation of private containers is hardly than just one private "container" (as now).
This game has no name. It will never be the same. ©

Return to Extension/Theme Releases


Who is online

Users browsing this forum: No registered users and 2 guests