font of bookmark menu not working

User Help for Mozilla Firefox
roninx
Posts: 106
Joined: May 25th, 2017, 3:07 pm

font of bookmark menu not working

Post by roninx »

My recent update of Firefox caused my bookmark toolbar font to change. I have it in my userchrome to use the consolas font, but it is no longer working. How can I get it working again?
morat
Posts: 6421
Joined: February 3rd, 2009, 6:29 pm

Re: font of bookmark menu not working

Post by morat »

Post the style...

Did you toggle the toolkit.legacyUserProfileCustomizations.stylesheets preference?

More info
http://www.ghacks.net/2019/05/24/firefo ... y-default/
roninx
Posts: 106
Joined: May 25th, 2017, 3:07 pm

Re: font of bookmark menu not working

Post by roninx »

morat wrote:Post the style...

Did you toggle the toolkit.legacyUserProfileCustomizations.stylesheets preference?

More info
http://www.ghacks.net/2019/05/24/firefo ... y-default/
Done (thanks), but it created 3 problems:

1) The hamburger button is back (I had it hidden). I can live with that if I must, but I'd rather not.
2) I had the tab bar hidden, but now it's back.
3) The more serious problem is that my bookmarks toolbar is 2 lines, but now it only shows the first line. How do I fix that?
morat
Posts: 6421
Joined: February 3rd, 2009, 6:29 pm

Re: font of bookmark menu not working

Post by morat »

Can you post the broken styles?

Are you using tweaks by Aris? I think the multiple bookmark lines is a CustomCSSforFx tweak.

CustomCSSforFx
http://github.com/Aris-t2/CustomCSSforFx
roninx
Posts: 106
Joined: May 25th, 2017, 3:07 pm

Re: font of bookmark menu not working

Post by roninx »

morat wrote:Can you post the broken styles?

Are you using tweaks by Aris? I think the multiple bookmark lines is a CustomCSSforFx tweak.

CustomCSSforFx
http://github.com/Aris-t2/CustomCSSforFx
I don't know what you mean, but here is my userchrome:

/* Set font size and family for dialogs
* and other miscellaneous text
*/
window {
font-size: 2.45mm !important;
font-family: consolos !important;
}
@namespace xul url(http://www.mozilla.org/keymaster/gateke ... s.only.xul);


#PersonalToolbar {
font-weight: bold !important;
}

#tabbrowser-tabs,
#tabbrowser-tabs > .tabbrowser-arrowscrollbox,
#tabbrowser-tabs[positionpinnedtabs] > .tabbrowser-tab[pinned] { min-height: initial !important; }

.tabbrowser-tab { line-height: 32px !important; height: 32px !important; }

.tabbrowser-tab:only-of-type,
.tabs-newtab-button,
#tabbrowser-tabs ~ .toolbarbutton-1 { display: none !important; }

#tabbrowser-tabs:hover .tabs-newtab-button,
#tabbrowser-tabs:hover ~ .toolbarbutton-1 { display: -moz-box !important; }

#PersonalToolbar {
min-height: unset !important;
max-height: unset !important;
/* text-align: center !important; */
}

#PersonalToolbar #PlacesToolbarItems {
overflow-x: visible !important;
overflow-y: visible !important;
display: inline-block !important;
}

/* Firefox userChrome.css */

@namespace url("http://www.mozilla.org/keymaster/gateke ... s.only.xul");

toolbarbutton.webextension-browser-action[label="Popup bookmark folder"] {
list-style-image: url("AU.png") !important;
-moz-image-region: auto !important;
}

@namespace url("http://www.mozilla.org/keymaster/gateke ... s.only.xul");

#BMB_unsortedBookmarks, #menu_unsortedBookmarks {
display: none !important;
}
/* Firefox userChrome.css */

@namespace url("http://www.mozilla.org/keymaster/gateke ... s.only.xul");

treechildren::-moz-tree-image(container, OrganizerQuery_UnfiledBookmarks)
{ list-style-image: none !important; }

treechildren::-moz-tree-cell-text(container, OrganizerQuery_UnfiledBookmarks)
{ color: transparent !important; }
#subscribeToPageMenuitem, #subscribeToPageMenupopup {
display: none !important; }

/* Firefox userChrome.css */

@namespace url("http://www.mozilla.org/keymaster/gateke ... s.only.xul");

toolbarbutton[id^="custombuttons-button"] menuitem[class="menuitem-iconic bookmark-item menuitem-with-favicon"] {
-moz-appearance: none !important;
padding-top: 12px !important;
padding-bottom: 12px !important;
}

/* Firefox userChrome.css */

@namespace url("http://www.mozilla.org/keymaster/gateke ... s.only.xul");

menu[class="menu-iconic bookmark-item"],
menuitem[class="menuitem-iconic bookmark-item menuitem-with-favicon"],
menuitem[class="openintabs-menuitem"] {
-moz-appearance: none !important;
padding-top: 4px !important;
padding-bottom: 4px !important;
}

.openintabs-menuseparator,
.openintabs-menuitem {
display: none !important;
}
/* Firefox userChrome.css */

@namespace url("http://www.mozilla.org/keymaster/gateke ... s.only.xul");

toolbarbutton[id^="custombuttons-button"] {
width: auto !important;
height: auto !important;
}

toolbarbutton[id^="custombuttons-button"] > .toolbarbutton-icon {
max-width: none !important;
}
/*AGENT_SHEET*/

/* Firefox 57+ userChrome.css tweaks ****************************************************/
/* code mostly taken from 'Classic Theme Restorer' & 'Classic Toolbar Buttons' add-ons **/
/* by Aris (aris-addons@gmx.net)*********************************************************/
/* Github: https://github.com/aris-t2/customcssforfx ************************************/
/****************************************************************************************/


/* import old button/bookmark size code */
@import url(./../buttons/buttons_on_bookmarks_toolbar_old_size_and_appearance.css);

:root {
--bookmark_items_height: 26px; /* <- bookmark items - line height */
--bookmark_items_lines: 3; /* <- maximum amount of lines */
}

#personal-bookmarks {
display: block;
}

#personal-bookmarks #PlacesToolbar {
display: block;
min-height: 0;
overflow-x: hidden;
overflow-y: auto;
max-height: calc( var(--bookmark_items_lines) * var(--bookmark_items_height) );
}

#personal-bookmarks #PlacesToolbar > hbox {
display: -moz-stack !important;
left: 0px;
right: 0px;
width: 100%;
}

#personal-bookmarks #PlacesToolbar #PlacesToolbarItems {
overflow-x: visible;
overflow-y: visible;
}

#personal-bookmarks #PlacesToolbar #PlacesToolbarItems > box {
display: block;
}

#personal-bookmarks #PlacesToolbar > .bookmark-item{
visibility: visible !important;
}

#personal-bookmarks #PlacesToolbar .chevron{
visibility: collapse;
}

#personal-bookmarks #PlacesToolbar > hbox > hbox{
overflow-x: hidden;
overflow-y: hidden;
}

#personal-bookmarks #PlacesToolbar #PlacesToolbarDropIndicator[collapsed="true"],
#personal-bookmarks #PlacesToolbar #PlacesToolbarDropIndicator{
display: none;
}

#personal-bookmarks #PlacesToolbar toolbarbutton.bookmark-item{
padding-top: 2px;
padding-bottom: 2px;
}

#personal-bookmarks #PlacesToolbar toolbarbutton.bookmark-item:hover:active:not([disabled="true"]),
#personal-bookmarks #PlacesToolbar toolbarbutton.bookmark-item[open="true"] {
padding-top: 2px !important;
padding-bottom: 2px !important;
}

#personal-bookmarks #PlacesToolbar toolbarseparator{
-moz-appearance: none !important;
visibility: visible !important;
display: inline;
text-shadow: none !important;
border-left: 3px solid ThreeDShadow !important;
border-right: 3px solid ThreeDHighlight !important;
vertical-align: middle;
}

#personal-bookmarks toolbarbutton.bookmark-item[dragover][open]{
-moz-appearance: toolbarbutton;
}

#navigator-toolbox #PersonalToolbar {
max-height: calc( var(--bookmark_items_lines) * var(--bookmark_items_height) ) !important;
}

@-moz-document url(chrome://browser/content/browser.xul){

}
}

/* Remove the Bookmark Star */
#star-button { display: none !important; }
#pageActionButton {
display: none;
}
#reader-mode-button,
#readinglist-addremove-button {
display:none !important;
}
#nav-bar-overflow-button {display: none !important}
#PanelUI-menu-button {display: none;}
}

#tabbrowser-tabs tab {
min-height: var(--tab-min-height)
}
morat
Posts: 6421
Joined: February 3rd, 2009, 6:29 pm

Re: font of bookmark menu not working

Post by morat »

You are using an id for the Custom Buttons addon which stopped working in Firefox 57.

i.e. "custombuttons-button"

The developers renamed "chrome://browser/content/browser.xul" to "chrome://browser/content/browser.xhtml" in Firefox 69.
morat wrote:Are you using tweaks by Aris?
roninx wrote:I don't know what you mean...
You have the comment "by Aris" in your userChrome.css file. That means you are using tweaks by Aris.

Mulitple Bookmark Lines Support Thread
http://github.com/aris-t2/customcssforfx/issues/99

bookmarks_toolbar_multiple_lines.css
http://github.com/Aris-t2/CustomCSSforF ... _lines.css

I don't want to help you with Aris' tweaks.
Last edited by morat on January 24th, 2020, 7:14 pm, edited 2 times in total.
roninx
Posts: 106
Joined: May 25th, 2017, 3:07 pm

Re: font of bookmark menu not working

Post by roninx »

morat wrote:You are using an id for the Custom Buttons addon which stopped working in Firefox 57.

i.e. "custombuttons-button"

The developers renamed "chrome://browser/content/browser.xul" to "chrome://browser/content/browser.xhtml" in Firefox 69.
morat wrote:Are you using tweaks by Aris?
roninx wrote:I don't know what you mean...
You have the comment "by Aris" in your userChrome.css file. That means you are using tweaks by Aris.

Mulitple Bookmark Lines Support Thread
http://github.com/aris-t2/customcssforfx/issues/99

I don't want to help you with Aris' tweaks.
I removed the custombuttons crap and changed the xul to xhtml.

Is there some reason you don't want to help with this "Aris" tweak? Is there another way to get this to work?
morat
Posts: 6421
Joined: February 3rd, 2009, 6:29 pm

Re: font of bookmark menu not working

Post by morat »

I don't use the CustomCSSforFx stuff and Aris has his own support threads.

One common problem is that users don't update the tweaks.

buttons_on_bookmarks_toolbar_old_size_and_appearance.css
http://github.com/Aris-t2/CustomCSSforF ... arance.css
roninx
Posts: 106
Joined: May 25th, 2017, 3:07 pm

Re: font of bookmark menu not working

Post by roninx »

morat wrote:I don't use the CustomCSSforFx stuff and Aris has his own support threads.

One common problem is that users don't update the tweaks.
Fair enough, but my question still remains, is there another way to do this, or should I just hope someone will help me?
morat
Posts: 6421
Joined: February 3rd, 2009, 6:29 pm

Re: font of bookmark menu not working

Post by morat »

You have 40 { and 42 }, that's a syntax error.
roninx wrote:1) The hamburger button is back (I had it hidden).
2) I had the tab bar hidden, but now it's back.
The selector for hamburger button is #PanelUI-menu-button. Try adding the !important rule.

The selector for tabs toolbar is #TabsToolbar. That selector is missing.
roninx
Posts: 106
Joined: May 25th, 2017, 3:07 pm

Re: font of bookmark menu not working

Post by roninx »

morat wrote:You have 40 { and 42 }, that's a syntax error.
roninx wrote:1) The hamburger button is back (I had it hidden).
2) I had the tab bar hidden, but now it's back.
The selector for hamburger button is #PanelUI-menu-button. Try adding the !important rule.

The selector for tabs toolbar is #TabsToolbar. That selector is missing.
Although I have a userchrome file, I know very little about how any of that works, so I need a little more to go on.

1) I don't see "40 { and 42 }" anywhere.
2) I don't see #TabsToolbar, so I assume I have to add some statement (?), what would that be?
3) I added the "!important" onto that #PanelUI-menu-button line, but it did nothing.
morat
Posts: 6421
Joined: February 3rd, 2009, 6:29 pm

Re: font of bookmark menu not working

Post by morat »

roninx wrote:I know very little about how any of that works.
Basic Syntax of CSS
http://www.w3schools.in/css3/basic-syntax/

1.

Example:

Code: Select all

#alpha {
  color: black;
}}
#beta {
  color: white;
}
In the example, there are two left curly brackets and three right curly brackets. That's a syntax error because the brackets are mismatched.

CSS Validation
http://jigsaw.w3.org/css-validator/#validate_by_input

2.

Code: Select all

/* hide tabs toolbar */

#TabsToolbar {
  display: none !important;
}
roninx
Posts: 106
Joined: May 25th, 2017, 3:07 pm

Re: font of bookmark menu not working

Post by roninx »

Sorry for the late reply, I've been really busy at work.

Anyhow, I looked at the validation and cleared all the errors except 2, but I don't know enough about CSS to understand what is wrong. See below at new userchrome code.

I also, added your little snippet at the beginning, but it did not work.


/* hide tabs toolbar */

#TabsToolbar {
display: none !important;
}

/* Set font size and family for dialogs
* and other miscellaneous text
*/
window {
font-size: 2.45mm !important;
font-family: consolas !important;
}

#PersonalToolbar {
font-weight: bold !important;
}

#tabbrowser-tabs,
#tabbrowser-tabs > .tabbrowser-arrowscrollbox,
#tabbrowser-tabs[positionpinnedtabs] > .tabbrowser-tab[pinned] { min-height: initial !important; }

.tabbrowser-tab { line-height: 32px !important; height: 32px !important; }

.tabbrowser-tab:only-of-type,
.tabs-newtab-button,
#tabbrowser-tabs ~ .toolbarbutton-1 { display: none !important; }

#tabbrowser-tabs:hover .tabs-newtab-button,
#tabbrowser-tabs:hover ~ .toolbarbutton-1 { display: -moz-box !important; }

#PersonalToolbar {
min-height: unset !important;
max-height: unset !important;
/* text-align: center !important; */
}

#PersonalToolbar #PlacesToolbarItems {
overflow-x: visible !important;
overflow-y: visible !important;
display: inline-block !important;
}

/* Firefox userChrome.css */

toolbarbutton.webextension-browser-action[label="Popup bookmark folder"] {
list-style-image: url("AU.png") !important;
-moz-image-region: auto !important;
}

#BMB_unsortedBookmarks, #menu_unsortedBookmarks {
display: none !important;
}
/* Firefox userChrome.css */

#subscribeToPageMenuitem, #subscribeToPageMenupopup {
display: none !important; }

/* Firefox userChrome.css */

menu[class="menu-iconic bookmark-item"],
menuitem[class="menuitem-iconic bookmark-item menuitem-with-favicon"],
menuitem[class="openintabs-menuitem"] {
-moz-appearance: none !important;
padding-top: 4px !important;
padding-bottom: 4px !important;
}

.openintabs-menuseparator,
.openintabs-menuitem {
display: none !important;
}
/* Firefox userChrome.css */

/*AGENT_SHEET*/

/* Firefox 57+ userChrome.css tweaks ****************************************************/
/* code mostly taken from 'Classic Theme Restorer' & 'Classic Toolbar Buttons' add-ons **/
/* by Aris (aris-addons@gmx.net)*********************************************************/
/* Github: https://github.com/aris-t2/customcssforfx ************************************/
/****************************************************************************************/

/* import old button/bookmark size code */

:root {

#personal-bookmarks {
display: block;
}

#personal-bookmarks #PlacesToolbar {
display: block;
min-height: 0;
overflow-x: hidden;
overflow-y: auto;
max-height: calc( var(--bookmark_items_lines) * var(--bookmark_items_height) );
}

#personal-bookmarks #PlacesToolbar > hbox {
display: -moz-stack !important;
left: 0px;
right: 0px;
width: 100%;
}

#personal-bookmarks #PlacesToolbar #PlacesToolbarItems {
overflow-x: visible;
overflow-y: visible;
}

#personal-bookmarks #PlacesToolbar #PlacesToolbarItems > box {
display: block;
}

#personal-bookmarks #PlacesToolbar > .bookmark-item{
visibility: visible !important;
}

#personal-bookmarks #PlacesToolbar .chevron{
visibility: collapse;
}

#personal-bookmarks #PlacesToolbar > hbox > hbox{
overflow-x: hidden;
overflow-y: hidden;
}

#personal-bookmarks #PlacesToolbar #PlacesToolbarDropIndicator[collapsed="true"],
#personal-bookmarks #PlacesToolbar #PlacesToolbarDropIndicator{
display: none;
}

#personal-bookmarks #PlacesToolbar toolbarbutton.bookmark-item{
padding-top: 2px;
padding-bottom: 2px;
}

#personal-bookmarks #PlacesToolbar toolbarbutton.bookmark-item:hover:active:not([disabled="true"]),
#personal-bookmarks #PlacesToolbar toolbarbutton.bookmark-item[open="true"] {
padding-top: 2px !important;
padding-bottom: 2px !important;
}

#personal-bookmarks #PlacesToolbar toolbarseparator{
-moz-appearance: none !important;
visibility: visible !important;
display: inline;
text-shadow: none !important;
border-left: 3px solid ThreeDShadow !important;
border-right: 3px solid ThreeDHighlight !important;
vertical-align: middle;
}

#personal-bookmarks toolbarbutton.bookmark-item[dragover][open]{
-moz-appearance: toolbarbutton;
}

#navigator-toolbox #PersonalToolbar {
max-height: calc( var(--bookmark_items_lines) * var(--bookmark_items_height) ) !important;
}

@-moz-document url(chrome://browser/content/browser.xhtml){
}

/* Remove the Bookmark Star */
#star-button { display: none !important; }
#pageActionButton {
display: none;
}
#reader-mode-button,
#readinglist-addremove-button {
display:none !important;
}
#nav-bar-overflow-button {display: none !important}
#PanelUI-menu-button {display: none !important}

#tabbrowser-tabs tab {
min-height: var(--tab-min-height)
}
morat
Posts: 6421
Joined: February 3rd, 2009, 6:29 pm

Re: font of bookmark menu not working

Post by morat »

You have 36 { and 35 }, that's a syntax error.

You can use the following utility to count the number of { and } characters.

Count character occurence
http://www.countcalculate.com/everyday- ... ds-in-text

The braces must always occur in matching pairs. The braces may be nested.

P.S.

You should learn how to post CSS using BBCode code tags.

BBCode code tags
http://www.phpbb.com/community/help/bbcode#f2r1

Otherwise, some users will ignore your threads.
Last edited by morat on January 18th, 2020, 5:19 pm, edited 1 time in total.
roninx
Posts: 106
Joined: May 25th, 2017, 3:07 pm

Re: font of bookmark menu not working

Post by roninx »

I fixed the syntax error, and this is my result:
96 #personal-bookmarks #PlacesToolbar Value Error : max-height Parse Error var(--bookmark_items_lines) * var(--bookmark_items_height) )
159 #navigator-toolbox #PersonalToolbar Value Error : max-height Parse Error var(--bookmark_items_lines) * var(--bookmark_items_height) ) !important
178 #tabbrowser-tabs tab Value Error : min-height Parse Error var(--tab-min-height)
Post Reply