James Ross has been doing a great job at getting Native Theme rendering on Windows to work correctly. James took on the bug after the recent checkin for Bug# 303806 (ugly menus for classic). Bug# 243078 is short on time for landing on branch for the Firefox 1.5 release and we can not let this patch miss the release and have firefox released half-assed looking so please, please test this patch throughly and report any bugs in this thread for James to see (please don't spam the bug). Thanks!
http://silver.warwickcompsoc.co.uk/temp/Firefox_1.5_Theme_Patch.zip (unzip into its own folder)
That's current trunk CVS from about 2 hours ago (2005091403 give or take a few hours), built with MSVC Toolkit with ActiveX disabled.
Known issues with the menus with patch:
- The height of menubar items is still that of the containing toolbar.
- Text colour for menubar items is incorrect when highlighted, when using certain flat-menu themes (e.g. standard Windows XP theme).
- In Bookmarks menu, the items without images have their text at a slightly different horizontal alignment to the bookmarks (which have images). The "Open in tabs" item is the worst out-of-line.