MozillaZine

[Needs Testing] Patch for Bug# 243078-Native Theme Rendering

Discussion of bugs in Mozilla Firefox
Thumper

User avatar
 
Posts: 8037
Joined: November 4th, 2002, 5:42 pm
Location: Linlithgow, Scotland

Post Posted October 17th, 2005, 11:09 am

And with that, this thread is officially carrion.

- Chris

Nitin
Moderator

User avatar
 
Posts: 3483
Joined: February 27th, 2003, 9:38 pm
Location: San Jose, CA

Post Posted October 17th, 2005, 11:23 am

Cusser wrote:There's been enough mud-slinging about the menu changes, can we all please just let it go?
If you're not using Firefox, you're not surfing the web, you're suffering it.
Join the MZ folding@home team.

Jweb_Guru
 
Posts: 74
Joined: September 7th, 2005, 9:50 pm

Post Posted October 17th, 2005, 1:29 pm

Voting most definitely has a purpose - getting yourself CCed to the MNG bug without killing Bugzilla.

Seriously, there's nothing inherently wrong with the voting process, and there's no particular reason to get rid of it except that people try to use it as a valid argument position - "This bug has xxx votes, it must be FIXED!" The flaws in this have been pointed out by the developers time and time again. That said, as long as people can accept that votes have little to nothing to do with the actual likelihood that a bug will be fixed, or when (crashes always receive much higher priority, unless they're rare and difficult to reproduce, but rarely get above five votes), voting should remain in Bugzilla.

Telling people not to bother voting, on the other hand, is dangerous, because that's when you really get people doing the whole "advocacy and commentary in Bugzilla" thing, flaming others, and generally making the situation unhelpful. Voting helps siphon off some of this.

And, finally, thank you, Nitin. Please stop flaming Thumper (or anyone else, for that matter). "Responsibility" is not an issue with this bug. Thumper was accurately pointing out that people started to work on the native theme rendering bug only because his bug got fixed, and he is also accurate in stating that there are structural problems with Mozilla (though not really the fix) that could not have been fixed shortly without changing the user experience more than James wanted to. We're (trying to) work on fixes for those, and they should show up in 2.0.

I'm not sure that trunk baking for the new patch will actually help, though, because trunk still has native menus (though I wish someone'd taken the imperfect solution out). So this may just not get in. Pity, but there you have it.

Thumper

User avatar
 
Posts: 8037
Joined: November 4th, 2002, 5:42 pm
Location: Linlithgow, Scotland

Post Posted October 17th, 2005, 1:48 pm

The fact is that so far I've never seen a bug which was fixed because of the amount of votes it has. Voting appears to be a placebo rather than anything else.

- Chris

Old RPGM35
 
Posts: 0
Joined: December 31st, 1969, 5:00 pm

Post Posted October 17th, 2005, 3:09 pm

Elfguy wrote:
supergirl260 wrote:it will probly get into the firefox 1.5.1 version though


I won't make any 1.5.x unless work continues on the branch. Unless I'm mistaken, trunk is the code that will only appear in 2.0?
Yes, stuff in the trunk will appear in 2.0

Elfguy
 
Posts: 309
Joined: June 27th, 2005, 5:56 pm

Post Posted November 11th, 2005, 4:55 pm

So are there still builds made from branch + this patch? I'm kind of dubious of recommending users to use trunk, so until it's stable enough I'm telling people to stay with 1.0 for now.

Old RPGM35
 
Posts: 0
Joined: December 31st, 1969, 5:00 pm

Post Posted November 11th, 2005, 5:06 pm

The only Branch build i know of with the patch in it is the one made by tongle some time ago, as the patch got backed out of the branch

BenBasson
Moderator

User avatar
 
Posts: 13671
Joined: February 13th, 2004, 5:49 am
Location: London, UK

Post Posted November 11th, 2005, 5:29 pm

I'll produce and distribute a branch build with this patch when 1.5 is released.

Jweb_Guru
 
Posts: 74
Joined: September 7th, 2005, 9:50 pm

Post Posted November 16th, 2005, 7:06 pm

Keep in mind, though, that the Classic Menus extension gives the same behavior, with the added bonus that the people you recommend it to can still use the autoupdater (unless the customized builds are going to have their own channels). So, for now, I'd suggest that over trunk or customized builds.

Actually, though, when it comes to trunk, about a week ago was about as stable as I think it's going to get for awhile. Cairo is going to land soon, and then you really won't want to recommend it to people.

BenBasson
Moderator

User avatar
 
Posts: 13671
Joined: February 13th, 2004, 5:49 am
Location: London, UK

Post Posted December 3rd, 2005, 11:06 am

Nonetheless, if you want a 1.5 build with native theme rendering feel free to help yourself:

http://www.cusser.net/misc/firefox/Fire ... eTheme.exe [Self-extracting RAR]
http://www.cusser.net/misc/firefox/Fire ... eTheme.rar

BoxerBoi76
 
Posts: 631
Joined: September 15th, 2004, 7:59 am
Location: Chicago, IL

Post Posted March 13th, 2006, 12:28 pm

Anyone know the status of this from James perspective? Is this going to make it for 2.0? I believe Asa stated (in his blog) that this was going to be a goal for 2.0 around the time that "#303806 [Firefox:General]-Wallpaper patch for better appearance on Windows XP / Luna [Win]" landed.

BoxerBoi76

mw22
 
Posts: 2379
Joined: November 19th, 2002, 5:37 pm

Post Posted March 13th, 2006, 1:25 pm

The patch probably suffers from bitrot.

BoxerBoi76
 
Posts: 631
Joined: September 15th, 2004, 7:59 am
Location: Chicago, IL

Post Posted March 13th, 2006, 9:17 pm

------- Comment #273 From James Ross 2006-03-13 14:55 PST [reply] -------

Until a decision is made on bug 313674, no, it cannot go forward. That decision critically affects the resulting appearance, and I can't call stage 1 (CSS-only version of the theme) done until that is decided.

Can someone assist James in getting a decision on bug 313674???

BoxerBoi76

mw22
 
Posts: 2379
Joined: November 19th, 2002, 5:37 pm

Post Posted March 14th, 2006, 4:22 am

You might wan to cc Mike Beltzner.

Return to Firefox Bugs


Who is online

Users browsing this forum: No registered users and 0 guests