The Official Win32 20060115 [Trunk] build is out.

Peter(6) · Post by **Peter(6)** » January 14th, 2006, 7:40 am

David Baron 20060114: Please file good memory leak bugs ! (bug 320915)

20060114 NEW URL !The Official Win32 ..... builds are out , RSS feed.
IRC channels: #firefox || #spreadfirefox || #bugs

The Official Win32 20060115 [Trunk] build is out.

Previous nightly 20060114 Trunk
Hourly Trunk builds:
PROMETHEUS (Lin) || CADENCE (Mac) || PACIFICA (Win)
ARGO (Lin-Cairo) || COLUMBIA (Mac-Cairo) || GAIUS (Win-Cairo)
Trunk Tinderbox || Cairo Trunk Tinderbox || Trunk Bonsai

Last update: 2006-01-15 -- 04:40 PST = 14:40 UTC (all check-ins since the latest nightly included)

Resolved Fixed:

#280742[Core:Preferences: Backend]-ignore_host GCONF key is not read in firefox proxy settings [Lin]
#304290[Firefox:Startup and Profile System]-Treeview of 'Choose Folder' Option in Create Profile/Profile Manager should not point at 'my documents' by default [All]
#320972[Core:Networking: HTTP]-Integrate extensions/auth into libxul [All]
#321228[Core:SVG]-Don't assume unknown platforms are Gtk [BeO]
#322725 [Core]-don't assume that all elements with tagname object implement nsIObjectLoadingContent.[All]
#322764[Core:Widget: Win32]-Win98SE and WinME / keyboard problem: Can't start trunk FFv1.6a1 or SMv1.5a.[Win](res by backout bug 287179)
#322813[Core:DOM: Views and Formatting]-CTRL+(+= key) to increase text size does not work [Win](res by backout bug 287179)
#323114[Core:XPConnect]-xptcstubs_linux_m68k.cpp needs fixing for gcc-4.0 [Lin]

Partial Landings/WIPs/Incoming:

#94687[Core:XP Toolkit/Widgets: XUL]-z-index style does not work properly in XUL [All]
#120527[Core:Themes]-When another button has focus, default button is still marked as default [Win]
#243078[Core:Themes]-Native Theme Rendering for Windows XP Menus, toolbars [Win]
#266932[Firefox:General]-Invalid HTML causes firefox to open different url than statusbar on new tab [All]
#268798[Core:ImageLib]-not flushing session cache during a memory-pressure notification [Win]
#277296[Core:Printing]-The print dialogs have no accesskeys [All]
#296526[Firefox:Location Bar and Autocomplete]-While autocomplete list is visible opening the context menu causes a misplacement, the focus is lost and a crash occurs when trying to load another URL [@nsAutoCompleteController::HandleEnter] [Win]
#301341[Core:JavaScript Engine]-make building narcissus w/ Makefile.ref easier [Win]
#307296[Firefox:Software Update]-MAR files do not contain updates to the uninstaller [Win]
#307558[Firefox:Toolbars]-customized toolbars are reset to default because of corrupt localstore.rdf after search plugin update check [Win]
#308372[Core:Web Services]-nsSchemaAttribute* needs to store the form attribute [All]
#309348[Core:Layout: Form Controls]-form will not submit when clicking the submit button [All]
#309459[Core:Networking: Cache]-Crash when using cacheService.visitEntries [@ nsMemoryCacheDevice::Visit] [Win]
#312241[Core:ImageLib]-nsIconURI::Clone and ::Resolve return NS_OK but don't do anything [Lin]
#312760[Core:Networking]-Provide base channel for use by protocol implementations [All]
#312867[Core:XP Toolkit/Widgets: XUL]-Implement textbox.reset(), expose input's editor [Win]
#313211[Core:Internationalization]-Improve universal charset detector test [Win]
#313295[Core:Layout: Tables]-hang due to many invalid col elements [Win]
#313309[Core:XPCOM]-Provide table-driven QI mechanism [All]
#313414[Core:Networking: HTTP]-There is no way to do "sandboxed" http connections that don't modify the cookie list [All]
#314993[Firefox:Preferences]-Color sheet in Preferences is not wide enough on Mac [Mac]
#316076[Core:Widget: Cocoa]-complete menu implementation Cocoa widgets [Mac]
#316582[Core:HTML: Parser]-Clean up style in parser/htmlparser [All]
#319107[Core:SVG]-One SVG file crashes firefox 1.5 [@ nsSVGGradientFrame::GetNextGradient] [All]
#320192[Core:Layout]-better way for users/testers to detect and isolate leaks of large object graphs [All]
#320504[Firefox:Installer]-Prompt users to submit feedback when uninstalling FF [Win]
#321098[Core:Event Handling]-onmouseover alert() causing multiple stacked alert dialogs [All]
#321446[Core:JavaScript Engine]-Javascript Assertion failure: !cx->throwing [Lin]
#322167[Core:History: Global]-Title chopping from bug 319004 might split a character in the middle [All]

mozStorage related:
#310636[Toolkit:Storage]-Make mozStorage a little more developer friendly [Lin]
#315940[Firefox:Places]-Unified "Places" View [All]
#317631[Firefox:Places]-Drag & Drop for Places [All]
#317633[Firefox:Places]-Undo/Redo for Places [All]
#318057[Firefox:Places]-Bookmark importer/exporter for bookmarks.html [All]
#318653[Firefox:Places]-Fill out history API [All]

Regressions/Annoying/Common bugs:

#281490[Firefox:Menus]-Many menu items in sidebar context menu don't work [All]
#302348[Firefox:Software Update]-Update fails partial update and then hangs when update not in FTP mirrors yet [All]
#308678[Core:JavaScript Engine]-Trunk Crash in Browser and MailNews [@ js_NewGCThing] [All]
#314819[Firefox:Find Toolbar / FastFind]-Exception in browser.xml when closing the history sidebar (nsITypeAheadFind.setDocShell) [All]
#315699[Firefox:General]-Auto-login Cookies not always working [Win]
#322414[Firefox:General]-frequent random crashes via adblock [@ nspr4.dll] [Win]
#322833[Firefox:Plugin Finder Service]-Can't install plugins [Win]
Memory leak tests
#168411[Firefox:Bookmarks]-Move bookmarks transactions into a JS service (adding a bookmark leaks the Add Bookmark dialog) [All]
#296474[Firefox:Toolbars]-Memory leak when customizing toolbars [All]
#323402[Firefox:Software Update]-Memory leak when update firefox and select 'Later' to restart later [Win]
#323443[Firefox:Bookmarks]-Memory leak when you add/remove a separator [Win]

To copy your useragent+buildtime to clipboard, use the Nightly Tester Tools extension. (from extensionsmirror)
Get the Update Channel Selector extension to update nightly builds. (from extensionsmirror)
Get more out of the Javascript Console, see this page for Console².
If you're a daily tester then backup the valuable data in your profile!

Trunk fixes since branching for 1.5 (20050812) = ~1918

Peter(6) · Post by **Peter(6)** » January 14th, 2006, 8:01 am

from yesterday:

supernova_00 wrote:Anyone confirm a leak here?
:# 323402 [Firefox] - Memory leak when update firefox and select 'Later' to restart later [Win]

Confirmed

supernova_00 · Post by **supernova_00** » January 14th, 2006, 8:07 am

Woo Hoo! lol. Like I saying earlier...I always thought there was a leak after doing that because that is what I always do when I upgrade, i leave firefox going for about an hour afterwards and then firefox becomes very unreponsive.

LordDeath · Post by **LordDeath** » January 14th, 2006, 8:44 am

will the rss feed get back?

Peter(6) · Post by **Peter(6)** » January 14th, 2006, 8:47 am

LordDeath wrote:will the rss feed get back?

Yes it will, there just seems to be a temp problem with the server (down).
I can host the feed myself if needed, we'll see

SHS` · Post by **SHS`** » January 14th, 2006, 10:23 am

From yesterday...

Peter(6) wrote:
SHS` wrote:I see there's a bug for random crashes... however I don't have adblock installed. Some talkbacks:

TB13932664Z
TB13844470Y
TB13844188W
3 different crashes

mw wrote:
SHS` wrote:I see there's a bug for random crashes... however I don't have adblock installed. Some talkbacks:

TB13932664Z
TB13844470Y
TB13844188W

I get this https://bugzilla.mozilla.org/show_bug.cgi?id=323234
Was that what you were doing when you got the crash?

I was just doing random things, though off hand... it seemed to be logging into page with javascript/flash, generally in website ads and so forth.

... and another for today: TB13950287W

Added a comment to that bug...

chob · Post by **chob** » January 14th, 2006, 10:31 am

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a1) Gecko/20060114 Firefox/1.6a1 ID:2006011405

1. New profile, start firefox with leak logging
2. Middle click on the BBC News RSS bookmark
3. Many tabs should now be loading.
4. Wait until the first tab you're on loads, then close firefox (whilst the other tabs are still loading)

This doesn't generate a leak all the time, but sometimes it does.

Leaked outer window 298b3a8 at address 298b3a8.
Leaked outer window 29aa0a0 at address 29aa0a0.
Leaked inner window 20f0d50 (outer 29aa0a0) at address 20f0d50.
... with URI "http://news.bbc.co.uk/2/hi/americas/4612838.stm".
Leaked inner window 2ec5140 (outer 298b3a8) at address 2ec5140.
... with URI "http://news.bbc.co.uk/2/hi/europe/4612802.stm".
Summary:
Leaked 4 out of 68 DOM Windows
Leaked 0 out of 60 documents
Leaked 0 out of 30 docshells

Worth filing? I suspect the leak only happens when tabs are destroyed when closing firefox, providing the tab is doing something specific at the time. Having 20 tabs open & loading whilst closing firefox probably makes the bug more obvious, but I can't get any more specific than that.

I guess that leakage when firefox is closing isn't too important anyway, since the whole app is being unloaded. But of course if the leakage is because of closing a tab at a specific time, then that can occur during normal browsing.

Also, blimey, much leakage when choosing to customize the toolbar.
1. New profile, run firefox with logging
2. Right click on toolbar > customize
3. Close customization pallet
4. Close firefox.

Leaked 4 out of 10 DOM Windows
Leaked 22 out of 30 documents
Leaked 0 out of 4 docshells

edit > this is #296474[Firefox:Toolbars]-Memory leak when customizing toolbars [Lin]

supernova_00 · Post by **supernova_00** » January 14th, 2006, 11:14 am

Ya customize toolbar definently is leaking.

chob · Post by **chob** » January 14th, 2006, 11:37 am

I see from yesterday that adding a new bookmark is also leaking, #168411[Firefox:Bookmarks]-Move bookmarks transactions into a JS service (adding a bookmark leaks the Add Bookmark dialog) [All]. Maybe it should also be noted that adding a seperator, or moving a bookmark (drag&drop in the bookmark manager) also leaks.

supernova_00 · Post by **supernova_00** » January 14th, 2006, 12:06 pm

Damn that script/log is working great.

Peter(6) · Post by **Peter(6)** » January 14th, 2006, 12:27 pm

The RSS feed url has changed !
See main post

supernova_00 · Post by **supernova_00** » January 14th, 2006, 12:56 pm

chob wrote:Maybe it should also be noted that adding a seperator, or moving a bookmark (drag&drop in the bookmark manager) also leaks.

I filed a bug for that and someone else that can debug this can figure out if its related.

#323443 [Firefox] - Memory leak when you add/remove a separator [Win]

mw22 · Post by **mw22** » January 14th, 2006, 2:50 pm

That's probably the same bug as the adding/removing bookmark memory leak. Got something to do with transaction managment or something like that.

edit:
see https://bugzilla.mozilla.org/show_bug.cgi?id=168411

canuckerfan · Post by **canuckerfan** » January 14th, 2006, 3:38 pm

any chance of this being checked in by 2.0:

https://bugzilla.mozilla.org/show_bug.cgi?id=264897

chob · Post by **chob** » January 14th, 2006, 3:58 pm

These leaks are all well and good, but I can't help thinking they're rather footling and can't be responsible for the excessive memory usage some users experience. After all, who spends their time customizing toolbars or bookmarking stuff? After spending an hour or so trying to get firefox to leak with a virgin profile, i'm finding it pretty hard to discover any leakage; perhaps certain extensions (or combinations of extensions) are very leaky.

I also wonder the users who get firefox using 100s MB of memory are experiencing one huge leak every so often, or a small leak that occurs very frequently. BTW, whilst using the leak-gauge.pl script is there any way to estimate the amount of memory leaked? I just don't want to spend an hour finding a leak only to discover it's 8 bytes every time the user holds CTRL and SHIFT and double-clicks on a javascript link when the option window is open or something.