"File -> Save Page As" does not save images fro

Discussion of bugs in Mozilla Firefox
Post Reply
hm2k
Posts: 58
Joined: July 20th, 2005, 9:39 am
Contact:

"File -> Save Page As" does not save images fro

Post by hm2k »

When you use File -> Save Page As, it doesn't save the images that are included by the CSS.
User avatar
dickvl
Posts: 54161
Joined: July 18th, 2005, 3:25 am

Post by dickvl »

Try this extension:
Save Complete - https://addons.mozilla.org/en-US/firefox/addon/2925
User avatar
goa103
Posts: 242
Joined: June 28th, 2003, 6:36 pm
Location: Lyon, France
Contact:

Post by goa103 »

dickvl wrote:Try this extension:
Save Complete - https://addons.mozilla.org/en-US/firefox/addon/2925


Thanks but has the bug already been reported ?
warhammerkid
Posts: 1
Joined: April 12th, 2007, 5:53 pm

Post by warhammerkid »

Yes the bug has been <a href="https://bugzilla.mozilla.org/show_bug.cgi?id=126309">reported</a> in part already, although the issue isn't just with images, it's with CSS processing in the component responsible for saving pages - it was never written. I created the extension as a starting point to improve my understanding of how stylesheets can be processed easily, and because my C++ skills at the time were pretty terrible. I would like to fix it eventually, but the extension will work in Firefox 3 if I can't get the code fix into that version.
User avatar
goa103
Posts: 242
Joined: June 28th, 2003, 6:36 pm
Location: Lyon, France
Contact:

Firefox bugs and XUL extension Vs. C++ core development

Post by goa103 »

warhammerkid wrote:Yes the bug has been <a href="https://bugzilla.mozilla.org/show_bug.cgi?id=126309">reported</a> in part already, although the issue isn't just with images, it's with CSS processing in the component responsible for saving pages - it was never written.


Thanks but I think this topic is more related to the CSS not fixed up by webbrowserpersist ("save page as, complete" omits background images) bug. But you're right, I read the comments and it seems the difficulty is to properly parse CSS files. IMHO I think the existing CSS parser should be used instead of using tricks like regular expressions to extract URIs.

warhammerkid wrote:I created the extension as a starting point to improve my understanding of how stylesheets can be processed easily, and because my C++ skills at the time were pretty terrible. I would like to fix it eventually, but the extension will work in Firefox 3 if I can't get the code fix into that version.


Well these bugs were reported in 2001 and 2002 and won't make it to Firefox 3 release as long as developers are not working on it. No one is currently assigned to fix them and they're not planned in any milestone. However I think fixing them using an extension is a great idea as I find extension release process far much smoother and flexible. You don't have to dig into Firefox C++ core to fix bugs, you can just implement your own features XUL-style.
Post Reply