Extra Line while replying
-
- Guest
Extra Line while replying
Hi,
Recently upgraded to ver 2.0.0.x
While replying to any of the mails, I find that extra lines get added up between my reply and the text to which the reply has to be sent.
Also, when I try to reply, the text from the sender appears directly without details like sent time, sent ID, etc.
Recently upgraded to ver 2.0.0.x
While replying to any of the mails, I find that extra lines get added up between my reply and the text to which the reply has to be sent.
Also, when I try to reply, the text from the sender appears directly without details like sent time, sent ID, etc.
-
- Moderator
- Posts: 14404
- Joined: May 3rd, 2007, 7:40 am
- Location: US
Re: Extra Line while replying
There should be only one added line when the compose window is opening, which is the one in which you start your text. Do you have a signature which may contain empty lines that show up in this way?jagsrao wrote:While replying to any of the mails, I find that extra lines get added up between my reply and the text to which the reply has to be sent.
Try Changequote, https://nic-nac-project.org/~kaosmos/ch ... te-en.htmlAlso, when I try to reply, the text from the sender appears directly without details like sent time, sent ID, etc.
Also, see http://kb.mozillazine.org/Reply_header_settings for built-in header options.
-
- Moderator
- Posts: 14404
- Joined: May 3rd, 2007, 7:40 am
- Location: US
Hmm, not really. How did you create the signature? You should use only a simple text editor for plain-text or manually coded HTML signatures, or Thunderbird itself for HTML signatures. I'm not seeing any additional blank lines anywhere between the "-- " separator and the end of the mail with my (plain-text) signature.
You are not quite clear where those extra lines appear, within the signature itself or above the separator? When composing, there should be exactly one empty line above that separator line. Also, check on any add-ons installed that may produce this, see if you can reproduce it in Thunderbird's safe mode.
You are not quite clear where those extra lines appear, within the signature itself or above the separator? When composing, there should be exactly one empty line above that separator line. Also, check on any add-ons installed that may produce this, see if you can reproduce it in Thunderbird's safe mode.
- chrizoo
- Posts: 374
- Joined: October 11th, 2006, 5:58 pm
sorry, I'm going to be more precise. First of all the problem only occurs, when you choose "start my reply above the quote" and "place my signature below my reply (above the quote)" in the TB options. The result is: blank line - signature - blank line - blank line - quote header - quoted text. As for your 1st paragraph: Yes, it's Notepad I use. You cannot get more texty than this ... Even if I just enter three letters, for example "sig", without any html tags, I get the blank lines. There is no interference from extension in my case.
PS: The blank lines are definitely not part of the signature, because any text I enter there is shown in black (my default color for composing in html) - as opposed to grey, which would indicate signature text.
PS: The blank lines are definitely not part of the signature, because any text I enter there is shown in black (my default color for composing in html) - as opposed to grey, which would indicate signature text.
Last edited by chrizoo on April 9th, 2008, 7:11 am, edited 2 times in total.
-
- Moderator
- Posts: 14404
- Joined: May 3rd, 2007, 7:40 am
- Location: US
Ok, I'm replying after the quote and have the signature at the bottom, thus I couldn't see that. The first blank line is where you enter your reply, so that's necessary. You don't have a separator because the signature is above the quote and has to be part of the text then, that's normal too. Then, I think you want to have some space between your reply with the signature and the quoted text, otherwise your signature would blend with the quote, or not?
I quickly had a look into the source, but couldn't find the definite place where those two lines are inserted. I'm not aware of preference setting, it may be simply hardcoded. It appears that you think differently, but two empty lines between the reply and the quote seem like a reasonable choice to me, allowing some distinction between your reply and the quoted text...
I quickly had a look into the source, but couldn't find the definite place where those two lines are inserted. I'm not aware of preference setting, it may be simply hardcoded. It appears that you think differently, but two empty lines between the reply and the quote seem like a reasonable choice to me, allowing some distinction between your reply and the quoted text...
Last edited by rsx11m on April 9th, 2008, 6:59 am, edited 1 time in total.
- chrizoo
- Posts: 374
- Joined: October 11th, 2006, 5:58 pm
Yes, I was referring to the two blank lines between the signature and the quoted text. I always have to delete one of them. If you do this one or two times you don't care, but when it's everytime and you write hundreds of mails, it's getting on your nerves. That's what signatures are for anyway ...
Thanks for looking into the code, that's real nice. So there is no way, from your perspective ? Could you tell me - just approximately - where I could look for that in the source ?
Or anybody, who can think of a workaround ?
Thanks for looking into the code, that's real nice. So there is no way, from your perspective ? Could you tell me - just approximately - where I could look for that in the source ?
Or anybody, who can think of a workaround ?
-
- Posts: 2177
- Joined: June 26th, 2005, 4:36 pm
- Location: Winter Garden, FL
-
- Moderator
- Posts: 14404
- Joined: May 3rd, 2007, 7:40 am
- Location: US
The main action seems to be happening in nsMsgCompose.cpp, where a couple of different functions handle the signature. The ones that caught my attention were ConvertAndLoadComposeWindow and SetSignature, where it appears that the second line break you see may actually come from the omitted "-- " separator when replying above the quote. I've stopped at this point, but you can take it from there if you want to.
I can reproduce the double-line with both plain-text and HTML composition as long as the quote is below the reply and the signature above the quote. That preference doesn't show up in my about:config settings, and I'm not running any extensions for this test.bkennelly wrote:Go to the Config Editor and filter on 'htmlSigText'. ... have you ruled out extensions by testing in Safe Mode?
- chrizoo
- Posts: 374
- Joined: October 11th, 2006, 5:58 pm
Thanks for staying with me on this ....
I have two machines, one with TB2 (no extensions installed) and one with TB1.5 (some extensions). I can reproduce the issue on both machines, so it's not extension-related. htmlSigText is not part of my about:config settings. Is there something I can set this to, in order to avoid the line break ?
(PS: I had a look into the code, but that's not my league unfortunately ....)
I have two machines, one with TB2 (no extensions installed) and one with TB1.5 (some extensions). I can reproduce the issue on both machines, so it's not extension-related. htmlSigText is not part of my about:config settings. Is there something I can set this to, in order to avoid the line break ?
(PS: I had a look into the code, but that's not my league unfortunately ....)
Last edited by chrizoo on April 9th, 2008, 11:09 am, edited 2 times in total.
-
- Moderator
- Posts: 14404
- Joined: May 3rd, 2007, 7:40 am
- Location: US
- chrizoo
- Posts: 374
- Joined: October 11th, 2006, 5:58 pm
bkennelly, you must really be an insider .... nothing on google and when metacrawing for htmlSigText, I found only a single result!
Here is part of the code ... I don't know if I truncated it too early, otherwise follow the link above...
In case you understand this:
Here is part of the code ... I don't know if I truncated it too early, otherwise follow the link above...
In case you understand this:
Code: Select all
nsXPIDLString prefSigText;
// the pref sig is always going to be treated as html
identity->GetUnicharAttribute("htmlSigText", getter_Copies(prefSigText));
// Now, if they didn't even want to use a signature, we should
// just return nicely.
//
if ((!useSigFile && prefSigText.IsEmpty()) || NS_FAILED(rv))
return NS_OK;
nsFileSpec testSpec(sigNativePath.get());
// If this file doesn't really exist, just bail!
if (!testSpec.Exists() && prefSigText.IsEmpty())
return NS_OK;
Last edited by chrizoo on April 9th, 2008, 11:16 am, edited 1 time in total.
-
- Posts: 2177
- Joined: June 26th, 2005, 4:36 pm
- Location: Winter Garden, FL
-
- Posts: 2177
- Joined: June 26th, 2005, 4:36 pm
- Location: Winter Garden, FL
Not unless you want to create a custom build. It is not controlled by a preference or JS file that could be easily modified; it is compiled in.
'htmlSigText' can only add, not remove signature text.
Your best hope is probably to search for a related change request in Bugzilla and vote for it, or open a new report if you cannot find one.
Code: Select all
if (reply_on_top == 1)
mCitePrefix.AppendLiteral("\n\n");
'htmlSigText' can only add, not remove signature text.
Your best hope is probably to search for a related change request in Bugzilla and vote for it, or open a new report if you cannot find one.