Help needed to adjust Fission to Firefox 3.5 on Mac [Fixed]

[zeniko]

Fission is currently quite broken under Firefox 3.5's default Mac theme (see screenshot). Not having access to a Mac myself, I need help by somebody who does and who could tell me what adjustments are needed to fix this.

Should you want to do this, please install Fission and see the file at chrome://fission/content/skin_firefox.css for what's currently being applied. Some of it might have to go, other bits amended or added.

Thanks in the name of the extension's Mac users.

[robcee]

it looks like there were some changes made to theming here. There are some new graphics for graphite on Mac.

http://mxr.mozilla.org/mozilla1.9.1/source/browser/themes/pinstripe/browser/urlbar/

likely related to:

https://bugzilla.mozilla.org/show_bug.cgi?id=481382

[robcee]

I *think* adding:


#urlbar[fission-skin^="Darwin3."][focused="true"] .textbox-input-box:-moz-system-metric(mac-graphite-theme),
#urlbar[fission-skin^="Darwin3."][focused="true"] #urlbar-icons:-moz-system-metric(mac-graphite-theme) {
background-image: url("chrome://browser/skin/urlbar/textfield-mid-focused-graphite.png");
}

to chrome://fission/content/skin_firefox.css

should give the right halo graphic in graphite, but I haven't tested it.

[zeniko]

should give the right halo graphic in graphite, but I haven't tested it.

Please do. Note that you should be able to apply these rules either with the Stylish extension or just by copying them into your userChrome.css.

[Aronnax!]

Hi,
i think
#urlbar[fission-skin^="Darwin3."][focused="true"] .fission-progress-stack {
background-image: url("chrome://browser/skin/urlbar/textfield-mid-focused.png");
}
is the problem - and you should add as well something like:
#urlbar[fission-skin^="Darwin3."][focused="true"] .fission-progress-stack:-moz-system-metric(mac-graphite-theme) {
background-image: url("chrome://browser/skin/urlbar/textfield-mid-focused-graphite.png");
}

by the way,
#urlbar[focused="true"] .textbox-input-box:-moz-system-metric(mac-graphite-theme),
#urlbar[focused="true"] #urlbar-icons:-moz-system-metric(mac-graphite-theme) {
height: 28px !important;
}
works in a userChrome.css as a quick as dirty hack to overwrite the problem.

Cheers

[robcee]

with arronax' suggestion for the userChrome.css, I have:

#urlbar[fission-skin^="Darwin3."][focused="true"] .fission-progress-stack:-moz-system-metric(mac-graphite-theme) {
background-image: url("chrome://browser/skin/urlbar/textfield-mid-focused-graphite.png");
}

#urlbar[fission-skin^="Darwin3."][focused="true"] .textbox-input-box:-moz-system-metric(mac-graphite-theme),
#urlbar[fission-skin^="Darwin3."][focused="true"] #urlbar-icons:-moz-system-metric(mac-graphite-theme) {
background-image: url("chrome://browser/skin/urlbar/textfield-mid-focused-graphite.png");
}

#urlbar[focused="true"] .textbox-input-box:-moz-system-metric(mac-graphite-theme),
#urlbar[focused="true"] #urlbar-icons:-moz-system-metric(mac-graphite-theme) {
height: 28px !important;
}

I'm not sure if we'd need the bottom three lines or not. (edit: in the final skin_firefox.css - pretty sure they're needed in userChrome.css)

Btw, nice suggestion for Stylish. I hadn't considered using it as a userChrome tool.

[zeniko]

Thanks for the tips, robcee and Aronnax! From looking at that bug and at the rules that worked for 3.0, I think we only need the .fission-progress-stack:-moz-system-metric bit and both .textbox-input.box and #urlbar-icons shouldn't have a background at all, so that the progress bar is actually visible.

I've uploaded a test build (v1.0.5.1+) for you to verify that this is indeed right. If possible, it'd be great if you could also quickly test with Firefox 3.0 to make sure that this doesn't regress anything. Thanks.

[Aronnax!]

I've uploaded a test build (v1.0.5.1+)

Hi,
works fine with Shiretoko + Minefield

Regards

[robcee]

verified working here too. Looks good! Thanks!

[zeniko]

I've released version 1.0.6 containing this fix. Thanks for your help!

[john123456]

confirmed and verified its working now thanks for the help

[LoudNoise]

You are replying to an elderly thread (year old). Locking.