[Ext] Classic Toolbar Buttons [Fx/Tb/Sm]

[Aris]

Classic Toolbar Buttons - Discussion Thread




Main page
https://addons.mozilla.org/addon/cstbb/ (main page)

Latest developer/beta build
https://addons.mozilla.org/addon/cstbb/versions/beta

Latest release
https://addons.mozilla.org/addon/cstbb/versions/ (download & changelog)

Last release for Firefox 29-44
https://addons.mozilla.org/addon/cstbb/versions/1.5.1 (download & changelog)

Collection of my legacy add-ons (previously on AMO): last reviewed versions (I removed all Firefox add-ons from AMO, because AMO lacks responsibility to keep add-ons review system clean. AMO allows troll parasites to anonymously post false reviews without properly moderating/removing them [like happened in the past].)


The add-on page contains a detailed list of all available features.

Thanks to rob64rock for many fixes and suggestions and all beta testers.

[rob64rock]

Aris,

A Bug Report or Enhancement Request for CSTB v1.0.7pre builds, tested on latest Win32 Nightly 14.0a1 builds on WinXp.

CSTB v1.0.7pre builds when using the Large Icon Mode CSTB setting on Nightly 14.0a1 builds needs to disable it's button border styling for the (Forward & Back Buttons) in regards to the Fx10+ Conditional Hidden Forward Button.


Here's the complete definition for the case that enables the Fx10+ Conditionally Hidden Forward Button:

Windows:

Code: Select all

window:not([chromehidden~=toolbar]) #navigator-toolbox[iconsize=large][mode=icons] > :-moz-any(#nav-bar[currentset*="unified-back-forward-button,urlbar-container"],#nav-bar:not([currentset])) > #unified-back-forward-button

Linux:

Code: Select all

window:not([chromehidden~=toolbar]) :-moz-any(#nav-bar[currentset*="unified-back-forward-button,urlbar-container"][mode=icons], #nav-bar:not([currentset])[mode=icons]) > #unified-back-forward-button > #forward-button

Changing any of these cases will disable Fx10+ Conditionally Hidden Forward Button.

(Windows) large icons mode: To small icons mode
icons only mode (not text): To 'Icons + Text' or Text
Nothing between the back/forward & urlbar: To back/forward + (toolbar widget) + urlbar

Fx10+ Conditionally Hidden Forward Button on Fx 14.0a1 in Fx Large Icon Mode without using CSTB v1.0.7pre2 or v1.0.7pre3:

Forward button Hidden:

Forward button Hidden Urlbar Identity Box Mouse Hovered:

Forward button Not Hidden:


Fx10+ Conditionally Hidden Forward Button on Fx 14.0a1 in Fx Large Icon Mode with using CSTB v1.0.7pre2 or v1.0.7pre3:

Forward button Hidden:

Forward button Hidden Urlbar Identity Box Mouse Hovered:

Forward button Not Hidden:

Forward button Not Hidden Mouse Hovered:


On Fx 14.0a1 in Fx Large Icon Mode with using CSTB v1.0.7pre2 or v1.0.7pre3(Hovered Effect Fix) Toolbar-buttons Type=["menu-button"] breakage:
Causes other toolbar-buttons on nav-bar to appear vertically stretched causing the nav-bar's height to increase.

(Example Add-ons: Add-on Update Checker 2.0b4, Inline Translator 1.2, Tab Utilities has option to convert the Tab Groups(panorama) button to a Toolbar-button Type=["menu-button"])
Note: For the time being I have moved toolbar-buttons Type=["menu-button"] off the nav-bar to fix the problem.


Here are two Add-ons that have incompatibilities with CSTB v1.0.7pre2 or v1.0.7pre3 on Fx 14.0a1:

• 1.) About Startup 1.9 if installed and enabled prior to updating to Nightly 14.0a1 03-22-2012 or later and after updating the browser to the latest Nightly 14.0a1 build and after a browser restart it causes CSTB button border styling in Fx small and large Icon Modes to be disabled and the CSTB options panel in the Add-on Manager appears Blank.(Disabling/Uninstalling About Startup 1.9 Fixes the problem, note problem doesn't occur on latest Fx Aurora 13.0a2)
  
  
• 2.) Test Pilot 1.2.1 if installed and enabled(Even without it's toolbar-button being placed on the Nav-bar). Causes other toolbar-buttons on nav-bar to appear vertically stretched causing the nav-bar's height to increase.(Note: Disabling/Uninstalling Test Pilot 1.2.1 Fixes the problem)
  

[GTK66]

https://bugzilla.mozilla.org/show_bug.cgi?id=738437

I filed this bug on this.

[rob64rock]

https://bugzilla.mozilla.org/show_bug.cgi?id=738437

I filed this bug on this.

Not long ago Mozilla Dev's Marked INVALID:
https://bugzilla.mozilla.org/show_bug.cgi?id=673695

[faulty_fox]

I don't think the devs are going to revert this change, what's done is done.

So thanks for the add-on. It already does a good job and I also like the fact that it's a restart-less add on, but it's evident that more work needs to be done, also the transitions from pressed to unpressed seem a bit laggy (at least here).

Still pretty awesome, looking forward to the final version.

[patrickjdempsey]

[*]2.) Test Pilot 1.2.1 if installed and enabled(Even without it's toolbar-button being placed on the Nav-bar). Causes other toolbar-buttons on nav-bar to appear vertically stretched causing the nav-bar's height to increase.(Note: Disabling/Uninstalling Test Pilot 1.2.1 Fixes the problem)
[/list]

Test Pilot is junk. I can't believe they still ship it with beta builds.

[patrickjdempsey]

Hmmm... you should probably be detecting what Theme is in use and disable your extension for non-default themes... it completely and utterly breaks Themes.

[rob64rock]

Hmmm... you should probably be detecting what Theme is in use and disable your extension for non-default themes... it completely and utterly breaks Themes.

The sounds like a good idea, as long Aris makes exceptions for the themes he as already made it compatible with or an provide an override option. Aris has made CSTB compatible with some other simple less complex themes like Lars Grizzly's and few others, I think. In my opinion CSTB is mainly for those that use the Default theme any ways....

[rob64rock]

Aris,

I uploaded a CSS style fix for CSTB v1.07pre3:
http://userstyles.org/styles/62993/fx14-cstb-1-07pre3-large-icons-toolbarbuttons-fix

This style fixes the Add-on toolbar-buttons type=["menu-button"] nav-bar breakage issue when using CSTB v1.07pre3 setting: (Navigation Toolbar "buttons" Large Icon View) for Fx 14.0a1 that I mentioned in my report above, and it also fixes some toolbar-button padding/margin issues with other toolbar-button types on the Nav-bar.

Before applying Style fix:


After applying style fix:


Note: This style does not fix the Forward & Back toolbar-button issues that pertain to the Fx feature "Fx10+ Conditionally Hidden Forward Button" mentioned in my report. You still have make CSTB 1.0.7 disable it's button border styling in regards to "Fx10+ Conditionally Hidden Forward Button".

[patrickjdempsey]

I don't even think it could be compatible with L.A.R.'s themes as I'm pretty sure he doesn't even have compatibility with Aero/white icons to begin with, only only claims compatibility with XP.

[rob64rock]

I don't even think it could be compatible with L.A.R.'s themes as I'm pretty sure he doesn't even have compatibility with Aero/white icons to begin with, only only claims compatibility with XP.

CSTB is compatible with Grizzly Toolbar button themes, Currently I'm using it with this one:
https://addons.mozilla.org/firefox/addon/modern-toolbar-icons/

[patrickjdempsey]

Ahhh I see you are using XP, his themes don't support Vista/7 aero.

[GTK66]

This for me is great. I cannot get it to work well with a Persona but with the default theme this is great. I closed that bug report as these devs would won't fix it anyway. I just hope they don't FUGLY up something else.

[rob64rock]

This for me is great. I cannot get it to work well with a Persona but with the default theme this is great. I closed that bug report as these devs would won't fix it anyway. I just hope they don't FUGLY up something else.

What persona theme are you having issues with when using CSTB v1.07pre3(Large Icon View Fx 14.0a1 setting)?

[JayhawksRock]

Edited for Fixes already made.

Great Extension Guys ! Working great in small icon mode in Fx 14.0a1 and UX on XP. Large icon mode is not bad with only buttons having dropmarkers needing work. On some the dropmarker becomes a seperate button and others the button ends up one button but with double the width. Examples of that would be Stylish and Lastpass buttons although I think buttons with a dropdown action don't even need dropmarkers. I hid them where I could in rob64rocks styles that I used.

Rob64rock, it looks like I can now abandon all those userstyles of yours that I've been using for years and trying to alter with some success. Thanks for your great work on them.