SpellBound Development version

[RobertJ]

It does not show up in the context menu either. The context menu is better as we get a menu key to open it.

It shows up for me. You need to have the focus (cursor) on the text box being spell checked.

[RobertJ]

I located the Javascript which controls the control + left click

Code: Select all

// displays a custom popup when ctrl+left-click on a misspelled word.
  onClickHandler: function(aEvent)
  {
    if (aEvent.button == 0 &&
        aEvent.ctrlKey &&
        aEvent.originalTarget.parentNode.nodeName != "scrollbar" &&
        SB_InlineHelpers.shouldShowPopup(aEvent))
      SB_InlineSC.showPopup(aEvent);
  },

If I change the second line to

Code: Select all

aEvent.altKey &&

The in line context suggestion window pops up on my Mac!!!!

Robert, I would prefer not to have to hack Spellbound every time there is a new release; also, I'm sure most Mac users (actually most all users) have no idea how to hack an extension.

It would seem that there are three ways of handling this:

1 - Put an option in the preferences

2 - Set up unique xpi package for OS X

3 - Change the inlineSpellCheck.js as follows

Code: Select all


  onClickHandler: function(aEvent)
  {
    if (aEvent.button == 0 &&
        (aEvent.ctrlKey ||  aEvent.altKey) &&
        aEvent.originalTarget.parentNode.nodeName != "scrollbar" &&
        SB_InlineHelpers.shouldShowPopup(aEvent))
      SB_InlineSC.showPopup(aEvent);
  },

Thanks for all your effort on this extension.

bob j


EDITED: JAN 11 2006 @ 11:05 GMT

[sdwilsh]

Wouldn't it be better to use the meta key (command key) since that is what replaces control on a Mac?

Code: Select all

onClickHandler: function(aEvent)
  {
    if (aEvent.button == 0 &&
        (aEvent.ctrlKey ||  aEvent.metaKey) &&
        aEvent.originalTarget.parentNode.nodeName != "scrollbar" &&
        SB_InlineHelpers.shouldShowPopup(aEvent))
      SB_InlineSC.showPopup(aEvent);
  },

Just my $.02

[Will Pittenger]

I must agree with RobertJ in that hacking extensions or Firefox is too much for most users. I don't even know how to do that. Anyone who wants the average IE user to pick Firefox instead must vote against requiring the hack.

[Old R.Marotta]

@RobertJ;

Where did you find "InlineSpellCheck.JS" ? - I Looked inside of the Spellbound package, but could not find it...

;; Would like to mod the file with the the above Fix from Comadre693....OR Better Yet...Can I Grab a copy of your Fix, But using Comadre693 "Control Key" fix?

- Ray

[Lee_Dailey]

howdy Robert S..

[0] thanks! this extension works just spiffy!

[1] various bits of info
- my ff info ...
Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8) Gecko/20051111 Firefox/1.5 - Build ID: 2005111116

- my tb info ...
Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8) Gecko/20051201 Thunderbird/1.5 - Build ID: 2005120115

- spellbound info
spellbound development version 0.9.8.20060108

[2] tb150/spellbound spell check diffs
noticed spell check differences in spellbound and tb150. for instance ...
- spellbound
2nd = misspelled
- tbird150
2nd = just fine

[3] myspell.dll version numbers
looked and found the dll files and the versions report this ...

spellbound myspell.dll
- company name = Mozilla Foundation
- product name = Thunderbird
- version = 1.8.20060.10209

tb150 myspell.dll
- company name = Mozilla Foundation
- product name = Thunderbird
- version = 1.8.20051.20115

perhaps item [2] is caused by item [3]? the en-us.dic and en-us.aff files seem to be identical so i don't think they are the cause.

take care,
lee

__________
edit - ee-lay an't-cay ell-spay oo-tay ood-gay, an-cay e-hay?

[Tannerman]

I upgraded to 0.9.8.20060108 and now I find that while the Extension notes typos inline, I can no longer click on them to get suggestions for correct spellings. I click and nothing happens. Is there a new setting a need to be aware of? I didn't have this problem with the previous Development version.

[Lee_Dailey]

howdy Tannerman,

ya hafta ctrl-lft-clk to get the list ...

hope that helps,
lee

[RobertJ]

@RobertJ;

Where did you find "InlineSpellCheck.JS" ? - I Looked inside of the Spellbound package, but could not find it...

;; Would like to mod the file with the the above Fix from Comadre693....OR Better Yet...Can I Grab a copy of your Fix, But using Comadre693 "Control Key" fix?

- Ray

The file is here

spellbound.jar [unzipped]/content/inlineSpellCheck.js"

[slick]

I downloaded the Dictionary to my desktop.

The instructions say:

1. Copy the link from the Installation page
2. Select the Tools menu
3. Select the Extensions menu item
4. Click Install

Item 4. I don't have an "Install"?

But Spellbound is working so much better than the old version.
Even without the Dictionary.

[Tannerman]

Thanks Lee. That helps! Was the change made to improve some buggy issue?

[Pete_L_P]

Robert S.

Thanks very, very much for implementing the Ctrl-Click feature for the pop-up menu. It always feels totally natural now. An absolute pleasure to use.

Pete

[XerBlade]

I downloaded the Dictionary to my desktop.

The instructions say:

1. Copy the link from the Installation page
2. Select the Tools menu
3. Select the Extensions menu item
4. Click Install

Item 4. I don't have an "Install"?

But Spellbound is working so much better than the old version.
Even without the Dictionary.

That would only work in Thunderbird or in Firefox with MR Tech Local Install installed (which adds the Install buttons from Thunderbird).
It doesn't matter, though, as those instructions are for Thunderbird anyway. In Firefox, all you have to do is click the link, and it will install the same as an extension would (the instructions given are the method to install an extension on Thunderbird, actually, since Thunderbird can't just go to the webpage and click the link, obviously).

Robert S.

Thanks very, very much for implementing the Ctrl-Click feature for the pop-up menu. It always feels totally natural now. An absolute pleasure to use.

Pete

It feels rather unnatural to me. Perhaps an option to select what key/mouse action triggers it would help. I'd personally like to have it on middle click, however that conflicts with a few other extensions (middle-clicking on text), extensions which I don't use anyway. Or I'd also like it on double-click, which also potentially conflicts with a planned future version of Dictionary Tooltip, which I do use, however, I disable the clicking options for that extension and just use the context menu anyway.

[Lee_Dailey]

Thanks Lee. That helps! Was the change made to improve some buggy issue?

howdy Tannerman,

from reading thru this thread, it seems apparent that it was done to avoid keystroke conflicts. there are several posts on the page your msg is on that talk about various conflicts that still exist and the request for workarounds.

take care,
lee

[Pete_L_P]

Thanks Lee. That helps! Was the change made to improve some buggy issue?

Many people, including me, complained that the simple left click got in the way when we saw a typo and just wanted to click and edit it. Clicking and editing is a habit formed over many years, and hard to break. You'd click and start typing and then notice the menu was up. Often times clicking and typing would activate an option off the pop up menu. It could get very annoying and very ugly.

Pete