MozillaZine


DTA is broken in SeaMonkey 2.53.13 beta

Discussion of bugs in Seamonkey
therube

User avatar
 
Posts: 21024
Joined: March 10th, 2004, 9:59 pm
Location: Maryland USA

Post Posted May 12th, 2022, 8:37 am

DTA is broken in SeaMonkey 2.53.13 beta
20220510210001

https://addons.thunderbird.net/en-US/se ... wnthemall/
downthemall-3.0.9-sm (from ATN)+CLOSE.FIX.xpi

(among other errors...)

Code: Select all
Warning: Unrecognized chrome manifest modifier 'platform'.
Source File: jar:file:///C:/TMP/SEA/dta-test/extensions/%7BDDC359D1-844A-42a7-9AA1-88A850A938A8%7D.xpi!/chrome.manifest
Line: 36

Code: Select all
Error: DownThemAll! (error) - failed to load chrome://dta-modules/content/utils.js [Exception: Failed to load module utils from: chrome://dta-modules/content/utils.js
missing ) after catch]
require@chrome://dta-modules/content/glue.jsm:468:11
@chrome://dta-modules/content/api.js:6:23
loadScript@chrome://dta-modules/content/glue.jsm:364:34
require@chrome://dta-modules/content/glue.jsm:460:5
@chrome://dta-modules/content/main.js:10:13
loadScript@chrome://dta-modules/content/glue.jsm:364:34
require@chrome://dta-modules/content/glue.jsm:460:5
setup_scope@chrome://dta-modules/content/glue.jsm:524:11
@chrome://dta-modules/content/glue.jsm:529:3
startup@jar:file:///C:/TMP/SEA/dta-test/extensions/%7BDDC359D1-844A-42a7-9AA1-88A850A938A8%7D.xpi!/bootstrap.js:23:19
callBootstrapMethod@resource://gre/modules/addons/XPIProvider.jsm:4470:27
startup@resource://gre/modules/addons/XPIProvider.jsm:2202:18
callProvider@resource://gre/modules/AddonManager.jsm:259:31
_startProvider@resource://gre/modules/AddonManager.jsm:726:5
startup@resource://gre/modules/AddonManager.jsm:893:14
startup@resource://gre/modules/AddonManager.jsm:3074:26
observe@jar:file:///C:/WLIB/Mozilla/SeaMonkey/omni.ja!/components/addonManager.js:63:29

Source File: chrome://dta-modules/content/utils.js
Line: 660
Fire 750, bring back 250.
Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.1.19) Gecko/20110420 SeaMonkey/2.0.14 Pinball CopyURL+ FetchTextURL FlashGot NoScript

TPR75
 
Posts: 1143
Joined: July 25th, 2011, 8:11 am
Location: Poland

Post Posted May 12th, 2022, 8:46 am

therube wrote:DTA is broken in SeaMonkey 2.53.13 beta
20220510210001


Could be this reason:
https://ircbot.comm-central.org:8080/se ... 08#c195070

therube

User avatar
 
Posts: 21024
Joined: March 10th, 2004, 9:59 pm
Location: Maryland USA

Post Posted May 12th, 2022, 9:07 am

(I get an "untrusted" on that link?)
Fire 750, bring back 250.
Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.1.19) Gecko/20110420 SeaMonkey/2.0.14 Pinball CopyURL+ FetchTextURL FlashGot NoScript

TPR75
 
Posts: 1143
Joined: July 25th, 2011, 8:11 am
Location: Poland

Post Posted May 12th, 2022, 10:39 am

therube wrote:(I get an "untrusted" on that link?)


A libera.chat logbot is available at [1] but currently uses a self signed certificate.

https://wiki.mozilla.org/SeaMonkey/Stat ... tion_Items

rdtom
 
Posts: 56
Joined: February 26th, 2016, 3:48 pm

Post Posted May 12th, 2022, 10:59 am

therube
Warning: Unrecognized chrome manifest modifier 'platform'.


You're using a unpatched version of DTA
You either need do do your own patches
OR use dirk's DTA 3.09.2

NOW on to the Errors:
Only shows a empty "DownThemAll - Make Your Selection" box

These two errors first occurred in build 20220418210003

ReferenceError: Iterator is not defined
chrome://dta/content/common/internalFunctions.js line 20
Code: Select all
   Cu.import("chrome://dta-modules/content/glue.jsm", this);
   (function() {
20      for (let [k,v] in new Iterator(require("constants"))) {
         Object.defineProperty(this, k, {value: v, enumerable:true});
      }
   }).call(this);


TypeError: unloadWindow is not a function
chrome://dta/content/dta/select.js Line: 286

Code: Select all
/**
 * Our real, kicks ass implementation of the UI
 */
Dialog = {

   get boxen() {
      return $('checkcontainer').getElementsByTagName('checkbox');
   },

   // will be called to initialize the dialog
   load: function() {
286      this.unload = unloadWindow(window, this.unload.bind(this));

      $('maskeditor-accept').label = _('button-accept');
      $('cancelbutton').label = $('maskeditor-cancel').label = _('button-cancel');

      try {
         // initialize or link lists
         let links = window.arguments[0];
         let images = window.arguments[1];

         let isPrivate = this.isPrivate =
            links.some(e => e.isPrivate) || images.some(e => e.isPrivate);

         // construct or dropdowns.
         this.ddFilter = $('filter');
         this.ddFilter.isPrivate = isPrivate;
         this.ddDirectory = $('directory');
         this.ddDirectory.isPrivate = isPrivate;
         this.ddRenaming = $('renaming');
         this.ddRenaming.isPrivate = isPrivate;
         $("maskeditor-selector").isPrivate = isPrivate;

         if (!this.ddDirectory.value) {
            log(LOG_DEBUG, "Using default download directory, value was " + this.ddDirectory.value);
            getDefaultDownloadsDirectory((function(path) {
               this.ddDirectory.value = path;
            }).bind(this));
         }

         // initialize the labels
         $("viewlinks").label = $("viewlinks").label + " ("+ links.length + ")";
         if (!links.length) {
            $('viewlinks').disabled = true;
         }
         $("viewpics").label = $("viewpics").label + " ("+ images.length + ")";
         if (!images.length) {
            $('viewpics').disabled = true;
         }

         // intialize our Trees (nsITreeview)
         // type parameter corresponds to Filter types
         this.links = new Tree(links, 1);
         this.images = new Tree(images, 2);

         // changeTab will initialize the filters and do the selection for us
         let preferredTab = Preferences.getExt("seltab", 0);
         FilterManager.ready((function() {
            if (preferredTab) {
               this.changeTab(!!images.length ? 'images' : 'links');
            }
            else {
               this.changeTab(!!links.length ? 'links': 'images');
            }
         }).bind(this));

         $("urlList").addEventListener(
            'keypress',
            function(evt) {
               if (evt.charCode === ' '.charCodeAt(0)) {
                  Dialog.toggleSelection();
                  evt.stopPropagation();
                  evt.preventDefault();
               }
            },
            true
         );

         this._notifications = $('notifications');
         for (let x in this._notifications) {
            if (!x.match(/^PRIORITY/)) {
               continue;
            }
            this[x] = this._notifications[x];
         }

         if (window.arguments[2]) {
            this.setNotification(window.arguments[2], this.PRIORITY_WARNING_HIGH, 4500);
         }
      }
      catch(ex) {
         log(LOG_ERROR, "load():", ex);
      }

      // will install our observer
      // currently just observes FilterManager
      this.registerObserver();
   },

rainyd
 
Posts: 23
Joined: November 14th, 2008, 1:22 pm

Post Posted May 16th, 2022, 6:56 am

rdtom wrote:You're using a unpatched version of DTA
You either need do do your own patches
OR use dirk's DTA 3.09.2


I'm using dirk's DTA and still no success - when I click on manager in tools, I'm getting message loading and then window of DTA simply disappear.

Btw, 2.53.13 beta 1 build from 15th May.

therube

User avatar
 
Posts: 21024
Joined: March 10th, 2004, 9:59 pm
Location: Maryland USA

Post Posted May 16th, 2022, 1:22 pm

A link would have helped ;-).

Dirk: https://github.com/dirkf/downthemall-legacy/releases

2.53.13 beta, 20220510210001

"Better", but still does not look to actually be working?

Code: Select all
Error: ReferenceError: Iterator is not defined
Source File: chrome://dta/content/common/internalFunctions.js
Line: 20

Code: Select all
Timestamp: 05/16/2022, 04:21:20 PM
Error: TypeError: unloadWindow is not a function
Source File: chrome://dta/content/dta/select.js
Line: 286

Code: Select all
Error: DownThemAll! (error) - failed to load filters [Exception: Iterator is not defined]
_reload/this._pending<@chrome://dta-modules/content/support/filtermanager.js:409:1
TaskImpl_run@resource://gre/modules/Task.jsm:327:57

Source File: chrome://dta-modules/content/support/filtermanager.js
Line: 409

Code: Select all
Error: DownThemAll! (error) - saveSingleLink [Exception: missing required information]
   turboSendLinksToManager() @ chrome://dta-modules/content/api.js:366
   saveSingleItem() @ chrome://dta-modules/content/api.js:336
   saveSingleLinkAsync/<() @ chrome://dta-modules/content/loaders/integration.js:469
   TaskImpl_run() @ resource://gre/modules/Task.jsm:326
Source File: chrome://dta-modules/content/api.js
Line: 366
Fire 750, bring back 250.
Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.1.19) Gecko/20110420 SeaMonkey/2.0.14 Pinball CopyURL+ FetchTextURL FlashGot NoScript

rdtom
 
Posts: 56
Joined: February 26th, 2016, 3:48 pm

Post Posted May 17th, 2022, 7:12 am

I should of indicated earlier in that post that was DTA 3.09.2 was broke too
Dirk has been notified and is working a patch
I'm in the process of examining code
But haven't come of with anything yet

rdtom
 
Posts: 56
Joined: February 26th, 2016, 3:48 pm

Post Posted May 27th, 2022, 3:17 pm

DTA fixes to date
clicking on DownThemAll!
Error: ReferenceError: Iterator is not defined
File: chrome/content/common/internalFunctions.js
Code: Select all
 Old New
 16        // shared state defines

            Cu.import("chrome://dta-modules/content/glue.jsm", this);
            (function() {
+               function Iterator(){
+               }
  20  22     for (let [k,v] in new Iterator(require("constants"))) {
                     Object.defineProperty(this, k, {value: v, enumerable:true});
                 }
             }).call(this);


Clicking on dTa! OneClick
Error: DownThemAll! (error) - failed to load filters [Exception: Iterator is not defined]
File: modules/support/filtermanager.js
Code: Select all
 Old New
                 // Load all
                 let all = [];
+     409    function Iterator() {
+               }
 409          for (let [id, obj] in Iterator(filters)) {
                    try {
                       let f = new Filter(id);
                       f.load(obj);
                       filters[f.id] = f;
                       all.push(f);
                    }


Clicking on Manager
Error: Failed to load module manager/connection from: modules/manager/connection.js
Ci.nsIProgrammingLanguage is undefined
Code: Select all
    Old New
                 contractID: null,
                 classDescription: "DownThemAll! connection",
                 classID: null,
?- 316       implementationLanguage: Ci.nsIProgrammingLanguage.JAVASCRIPT,
       316    flags: Ci.nsIClassInfo.MAIN_THREAD_ONLY,


I can get rid of the error by deleting line 316
But then I get 2 more errors
Timestamp: 5/27/2022, 5:47:58 AM
Error: ReferenceError: QUEUED is not defined
Source File: chrome://dta/content/dta/manager/manager.js
Line: 1449
Timestamp: 5/27/2022, 5:47:59 AM
Error: ReferenceError: REFRESH_FREQ is not defined
Source File: chrome://dta/content/dta/manager/manager.js
Line: 636

therube
this error
TypeError: unloadWindow is not a function dta/content/dta/select.js
Is caused by the previous error:
ReferenceError: Iterator is not defined dta/content/common/internalFunctions.js

This error I haven't encountered
Error: DownThemAll! (error) - saveSingleLink [Exception: missing required information]
dta-modules/content/api.js
dta-modules/content/api.js Line: 366

rainyd
 
Posts: 23
Joined: November 14th, 2008, 1:22 pm

Post Posted June 17th, 2022, 2:28 pm

rdtom wrote:Dirk has been notified and is working a patch


Any news about patch?

Return to SeaMonkey Bugs


Who is online

Users browsing this forum: No registered users and 1 guest